From owner-svn-src-all@freebsd.org Wed Aug 7 21:04:26 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C3EB2B7DA6; Wed, 7 Aug 2019 21:04:26 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463kXB4n3yz4LGH; Wed, 7 Aug 2019 21:04:26 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-vs1-f54.google.com with SMTP id j26so61624116vsn.10; Wed, 07 Aug 2019 14:04:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R9Y/Kz8/B5pR78bDbKMlIiAx4P+5sHZ6XtOOWa4mOZY=; b=fj6h6XpoXkXZvz63c+KK2ImV7LTukyQ/bpjsldwQeEllKT7a3uzB0fTSO299bkXhNn 0ntSjCEJzB0bZ5wYs3RTXYiCkWRn3hIpwf9jTcYQJMVHz57AJHeShki+IDeGQxbunDoU UgM1muwqK5+pLk2jJMSt01L4QArkwnx2C16r3rnPFQyTSzGc8ebH93HgtTV8P9EL3E1o DcVTLsZX3IUGqqKQ8zsw4inky+qmIvdo/CUDbHPy+JEE/DiXDMSgo9HXgJCXjW8sC+8P mK12hs6EJPxpLNHZ3B6wQjl5gd9+LDtfYE3n1BsPY6ZPEBRpgwmggAzsE5ZEVZnHBH1S GQHA== X-Gm-Message-State: APjAAAVdNPmV3HTa5IYpRI7RKuqCQlSLN7D6pfJsJGE+vKlwGKRgIqcz BpVpkZmeywPY72JiXG21+VqPBXc0e1AR8iXhnujsUQ== X-Google-Smtp-Source: APXvYqy8eUxXgmSkQwPzFgBe8W89Jh8L/5SAfrF51ifQsOx3WWFNBfPZe34OTCBgG3E2axoY8+4MxgHouE5vGw2nD+E= X-Received: by 2002:a05:6102:458:: with SMTP id e24mr7052529vsq.31.1565211865028; Wed, 07 Aug 2019 14:04:25 -0700 (PDT) MIME-Version: 1.0 References: <201908011819.x71IJG0M076399@repo.freebsd.org> <20190807202732.GD1377@raichu> In-Reply-To: <20190807202732.GD1377@raichu> From: Li-Wen Hsu Date: Thu, 8 Aug 2019 05:04:13 +0800 Message-ID: Subject: Re: svn commit: r350512 - head/tests/sys/kern To: Mark Johnston Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 463kXB4n3yz4LGH X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2019 21:04:26 -0000 On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston wrote: > > On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote: > > Author: lwhsu > > Date: Thu Aug 1 18:19:16 2019 > > New Revision: 350512 > > URL: https://svnweb.freebsd.org/changeset/base/350512 > > > > Log: > > Only skip test cases sometimes failing in CI when they are running in CI > > > > Suggested by: jhb > > Sponsored by: The FreeBSD Foundation > > This seems to break running the tests manually; atf dies because the > "ci" variable is not defined. I have to use an invocation like this to > avoid that: > > $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test > > I suspect that share/mk/suite.test.mk needs to be augmented somehow to > set this variable to "false" by default, so that the CI infrastructure > can override that. Thanks for catching this! I feel that the better approach is using function that gets this variable with default value, for keeping things simple. Best, Li-Wen