From owner-p4-projects@FreeBSD.ORG Mon Oct 24 18:42:55 2011 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CB1BF1065673; Mon, 24 Oct 2011 18:42:55 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DC2F106566C for ; Mon, 24 Oct 2011 18:42:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 7C16C8FC14 for ; Mon, 24 Oct 2011 18:42:55 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id p9OIgt6r084562 for ; Mon, 24 Oct 2011 18:42:55 GMT (envelope-from jhb@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id p9OIgtKj084559 for perforce@freebsd.org; Mon, 24 Oct 2011 18:42:55 GMT (envelope-from jhb@freebsd.org) Date: Mon, 24 Oct 2011 18:42:55 GMT Message-Id: <201110241842.p9OIgtKj084559@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to jhb@freebsd.org using -f From: John Baldwin To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 200663 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 18:42:56 -0000 http://p4web.freebsd.org/@@200663?ac=10 Change 200663 by jhb@jhb_jhbbsd on 2011/10/24 18:41:54 Use V_CLEANONLY and vm_object_page_cache() for FADV_DONTNEED to avoid losing data in dirty buffers and to move pages into cache rather than free'ing them outright. Affected files ... .. //depot/projects/fadvise/sys/kern/vfs_default.c#5 edit Differences ... ==== //depot/projects/fadvise/sys/kern/vfs_default.c#5 (text+ko) ==== @@ -1017,13 +1017,13 @@ VOP_UNLOCK(vp, 0); break; } - vinvalbuf(vp, V_NORMAL, 0, 0); + vinvalbuf(vp, V_CLEANONLY, 0, 0); if (vp->v_object != NULL) { start = trunc_page(ap->a_start); end = round_page(ap->a_end); VM_OBJECT_LOCK(vp->v_object); - vm_object_page_remove(vp->v_object, OFF_TO_IDX(start), - OFF_TO_IDX(end), OBJPR_CLEANONLY); + vm_object_page_cache(vp->v_object, OFF_TO_IDX(start), + OFF_TO_IDX(end)); VM_OBJECT_UNLOCK(vp->v_object); } VOP_UNLOCK(vp, 0);