From owner-cvs-all  Mon Jan 14  1: 8:41 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id C14FB37B402; Mon, 14 Jan 2002 01:08:33 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA14231;
	Mon, 14 Jan 2002 20:08:31 +1100
Date: Mon, 14 Jan 2002 20:09:34 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: Alfred Perlstein <alfred@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/contrib/ipfilter/ipsend sock.c
In-Reply-To: <20020114103437.A85961@sunbay.com>
Message-ID: <20020114195528.T5016-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 14 Jan 2002, Ruslan Ermilov wrote:

> On Mon, Jan 14, 2002 at 04:20:23PM +1100, Bruce Evans wrote:
> > On Sun, 13 Jan 2002, Alfred Perlstein wrote:
> > >...
> > >   Log:
> > >   add queue.h, now needed for file.h
> > >...
> >
> > This is file.h's responsibility.  file.h already includes queue.h, so
> > the problem must be elsewhere.  Anyway, it is a bug if changes of
> > kernel implementation details affect prerequisites in applications.
> >
> Moving <sys/queue.h> from after <sys/_mutex.h> to before <sys/_lock.h>
> in file.h should fix the problem.

Right.  <sys/_lock.h> and <sys/_mutex.h> use the queue macros and don't
include <sys/queue.h>, so headers that include them must include
<sys/queue.h> first.

When fixing this, please also remove the new bogus include of <sys/types.h>
from <sys/file.h>.  <sys/types.h> has been a prerequisite for <sys/file.h>
in the kernel for at least 10 years, so everything that included
<sys/file.h> already included this prerequisite (usually indirectly
via <sys/param.h>).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message