Date: Thu, 24 Oct 2013 02:58:31 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: portmgr@FreeBSD.org Subject: ports/183277: [PATCH] ports-mgmt/pkg: fix WITH_DEBUG=yes build Message-ID: <E1VZ9Fv-000GVN-Du@apollo.emma.line.org> Resent-Message-ID: <201310241720.r9OHK0JI025735@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 183277 >Category: ports >Synopsis: [PATCH] ports-mgmt/pkg: fix WITH_DEBUG=yes build >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Oct 24 17:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Matthias Andree >Release: FreeBSD 9.2-RELEASE amd64 >Organization: >Environment: System: FreeBSD apollo.emma.line.org 9.2-RELEASE FreeBSD 9.2-RELEASE #4: Thu Oct 17 06:54:18 CEST 2013 >Description: When building pkg whilst setting WITH_DEBUG=yes, the build runs unoptimized and with -g flags (in CFLAGS), but the staging strips the symbols again (uses install -s ...). The attached patch makes sure that the DEBUG_FLAGS we get propagate through the port's Makefile. Note 1: This triggers a shortcoming in Scripts/qa.sh that should not complain about individual unstripped binaries if WITH_DEBUG=yes is set. Note 2: I have already fixed debug4ports in the same manner earlier this year (ports r319812), so perhaps this needs to be moved into the ports framework, but we can only do that if the port's own Makefiles use <bsd.subdir.mk> or thereabouts. Other ports use DEBUG_FLAGS in a different context (examples: busybox, putty, Berkeley DB ports). Port maintainer (portmgr@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports) >How-To-Repeat: >Fix: --- pkg-1.1.4_9.patch begins here --- diff -ruN /usr/ports/ports-mgmt/pkg/Makefile ./Makefile --- /usr/ports/ports-mgmt/pkg/Makefile 2013-10-14 00:33:48.000000000 +0200 +++ ./Makefile 2013-10-24 02:54:31.000000000 +0200 @@ -1,8 +1,8 @@ -# $FreeBSD: ports-mgmt/pkg/Makefile 330262 2013-10-13 22:33:48Z bdrewery $ +# $FreeBSD: head/ports-mgmt/pkg/Makefile 330262 2013-10-13 22:33:48Z bdrewery $ PORTNAME= pkg DISTVERSION= 1.1.4 -PORTREVISION= 8 +PORTREVISION= 9 CATEGORIES= ports-mgmt MASTER_SITES= http://files.etoilebsd.net/pkg/ \ http://mirror.shatow.net/freebsd/${PORTNAME}/ \ @@ -26,6 +26,7 @@ # Use a submake as 'deinstall install' needs to reevaluate PKG_CMD # so that pkg-static is used from the wrkdir USE_SUBMAKE= yes +MAKE_ARGS+= DEBUG_FLAGS="${DEBUG_FLAGS}" .include <bsd.port.pre.mk> --- pkg-1.1.4_9.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1VZ9Fv-000GVN-Du>