From owner-svn-src-all@FreeBSD.ORG Thu Jan 14 12:50:59 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B30781065693; Thu, 14 Jan 2010 12:50:59 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com [209.85.221.174]) by mx1.freebsd.org (Postfix) with ESMTP id 2CAB98FC19; Thu, 14 Jan 2010 12:50:58 +0000 (UTC) Received: by qyk4 with SMTP id 4so11543174qyk.7 for ; Thu, 14 Jan 2010 04:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=3DhMqguGr+Sk70Ryx4dNIRL0ihQAvFTAIs+S5TsAyew=; b=BGX60GPx4tw+50/S75QWekvAJRgULCJ0lXsFOiYcbhBpUCEuJXSwQp6dgos2qpst1m QaHHSkSiqC3fFsEz2PTl/KHkgjrASeORt+vUa58Tk6g4tz1v9s/HRTKrVHPYSVIKVLtU Xa6D+Jj1sI0ZD9IX0yq1ajQyuPIAtT9xslRfg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=f5fflfvrvJmJ/1ByyUH1y+FOhNZg66MuxSeiTvYjOjGOVQtr2+u1BMczJq/Xv22/c+ ui5mVaOfxW+MRPzsL7u25uYZpu9EJmwr+voYmRWwrWth1SxKN6VQak20LlnfFPXUIxX+ TBEZ/Wv7dge2tSFcX7lXtS//Jvg2C8fds3+Eo= Received: by 10.224.69.164 with SMTP id z36mr494824qai.377.1263473453707; Thu, 14 Jan 2010 04:50:53 -0800 (PST) Received: from kan.dnsalias.net (c-24-91-218-112.hsd1.ma.comcast.net [24.91.218.112]) by mx.google.com with ESMTPS id 8sm1733472qwj.43.2010.01.14.04.50.51 (version=SSLv3 cipher=RC4-MD5); Thu, 14 Jan 2010 04:50:52 -0800 (PST) Date: Thu, 14 Jan 2010 07:50:46 -0500 From: Alexander Kabaev To: Ed Schouten Message-ID: <20100114075046.6a2ebb71@kan.dnsalias.net> In-Reply-To: <201001141000.o0EA0182095910@svn.freebsd.org> References: <201001141000.o0EA0182095910@svn.freebsd.org> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/yIKllgEyDeoejAqG6=xLErk"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r202279 - head/lib/libc/gen X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2010 12:50:59 -0000 --Sig_/yIKllgEyDeoejAqG6=xLErk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 14 Jan 2010 10:00:01 +0000 (UTC) Ed Schouten wrote: > Author: ed > Date: Thu Jan 14 10:00:01 2010 > New Revision: 202279 > URL: http://svn.freebsd.org/changeset/base/202279 >=20 > Log: > Revert the change to Symbol.map, made in r202274. > =20 > Even though we use __sym_compat(), we should list the symbol in > Symbol.map. > =20 > ttyslot() is now listed as follows, which seems to do the right > thing:=20 > | Symbol table '.dynsym' contains 2755 entries: > | Num: Value Size Type Bind Vis Ndx Name > | 613: 00000000000477b0 121 FUNC GLOBAL DEFAULT 10 > ttyslot@FBSD_1.0=20 > Reported by: kib >=20 > Modified: > head/lib/libc/gen/Symbol.map >=20 > Modified: head/lib/libc/gen/Symbol.map > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libc/gen/Symbol.map Thu Jan 14 09:38:23 > 2010 (r202278) +++ head/lib/libc/gen/Symbol.map Thu Jan > 14 10:00:01 2010 (r202279) @@ -272,6 +272,7 @@ FBSD_1.0 { > openlog; > closelog; > setlogmask; > + ttyslot; > ttyname_r; > ttyname; > timezone; Unnecessary, despite of what kib says. It was exported with proper version by __sym_compat already. This line in Symbol map is a NOP because there's no unadorned global 'ttyslot' symbol in the library for it to apply. Please back it out.=20 --=20 Alexander Kabaev --Sig_/yIKllgEyDeoejAqG6=xLErk Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFLTxMqQ6z1jMm+XZYRAspwAJsFVmiHBfeVhwKfDEkHHzxkqKBPigCghqJ1 cHdAktiy1OSpIB4fMHi6XEM= =mAXj -----END PGP SIGNATURE----- --Sig_/yIKllgEyDeoejAqG6=xLErk--