From owner-svn-src-projects@freebsd.org Thu Nov 16 23:47:45 2017 Return-Path: <owner-svn-src-projects@freebsd.org> Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37374DEDC8E for <svn-src-projects@mailman.ysv.freebsd.org>; Thu, 16 Nov 2017 23:47:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 07AB371385; Thu, 16 Nov 2017 23:47:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 068AECF58; Thu, 16 Nov 2017 23:47:44 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id DF9762A9B; Thu, 16 Nov 2017 23:47:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id NHzeuySRS2hL; Thu, 16 Nov 2017 23:47:39 +0000 (UTC) Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com A883A2A96 To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org References: <201711161513.vAGFDThx060235@repo.freebsd.org> <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org> <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> From: Bryan Drewery <bdrewery@FreeBSD.org> Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <b95ef558-751e-af4f-3b28-ea71202bf784@FreeBSD.org> Date: Thu, 16 Nov 2017 15:47:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bde0g249v2wHScUXbMpLLPDd8nThlmnOC" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" <svn-src-projects.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/> List-Post: <mailto:svn-src-projects@freebsd.org> List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 16 Nov 2017 23:47:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bde0g249v2wHScUXbMpLLPDd8nThlmnOC Content-Type: multipart/mixed; boundary="0bnLOvSIiUw0gsuupQkoeXgdMAoTWpKUN"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Message-ID: <b95ef558-751e-af4f-3b28-ea71202bf784@FreeBSD.org> Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 References: <201711161513.vAGFDThx060235@repo.freebsd.org> <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org> <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> In-Reply-To: <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> --0bnLOvSIiUw0gsuupQkoeXgdMAoTWpKUN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/16/2017 1:12 PM, Hans Petter Selasky wrote: > On 11/16/17 17:56, Bryan Drewery wrote: >> On 11/16/2017 7:13 AM, Hans Petter Selasky wrote: >>> Author: hselasky >>> Date: Thu Nov 16 15:13:28 2017 >>> New Revision: 325894 >>> URL: https://svnweb.freebsd.org/changeset/base/325894 >>> >>> Log: >>> =C2=A0=C2=A0 Update list of hardcoded OFED build order dependencies f= or >>> =C2=A0=C2=A0 the buildworld target. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0=C2=A0 Mellanox Te= chnologies >>> >>> Modified: >>> =C2=A0=C2=A0 projects/bsd_rdma_4_9/Makefile.inc1 >>> >=20 > Hi, >=20 >>> >> >> This isn't right, you don't need to include any 'include' directories = in >> here as 'make includes' is ran before 'make libraries'. >=20 > I tried leaving the include directory out and it failed. 1. I don't see any reason for that. You shouldn't need contrib/ofed/include__L anywhere nor contrib/ofed/include in _ofed_lib li= st. I see contrib/ofed/include hooked up fine for 'make _includes' so long as WITH_OFED is defined. What was the error? 2. Unrelated but I don't like the new directory structure of contrib/ofed/usr.bin/* -> contrib/ofed/*. Now we have contributed sources in with our FreeBSD Makefiles. It also makes it more complex in the _ofed_lib list since before we could just have contrib/ofed/usr.lib but now must list out every library.= 3. contrib/ofed/Makefile is also super complex now. It should really just look like the Makefile.inc1 changes (minus the include and libthr directories). Just add a .WAIT after include in SUBDIR and make it first= =2E You have this chained dependency thing but dependencies are already inherited just fine. SUBDIR_DEPEND_foo=3D bar SUBDIR_DEPEND_baz=3D foo baz will implicitly depend on bar being built, there's no need to explicitly add bar as a dependency but it's not wrong to do so if it has a LIBADD on it. >=20 >> >> You don't need libthr either as it is in prebuild_libs which is built >> before all of this. >=20 > OK. I'll update it tomorrow. >=20 >> >> I suspect the actual change needed is far smaller than this. >> >=20 > Thank you for your review. >=20 > --HPS --=20 Regards, Bryan Drewery --0bnLOvSIiUw0gsuupQkoeXgdMAoTWpKUN-- --bde0g249v2wHScUXbMpLLPDd8nThlmnOC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaDiOHAAoJEDXXcbtuRpfPiA0H/3Kv0Wt4DdEEmtNkkQoAPAW6 Evdi5nuSCwviclhoHx+/YUX9z8I4U2cseqZYMImRmhAC+8w1OYMnVbFndXGFZLBy zm/MPJRJPJ1p1+8P3kX73RGvDoUCTCJYBtzFDpwGB6vVSNBH0x4kb+cQvVOETwUm Zsimg+R8oQjnvaf+tLDxUbrrR88+fUGvaOx+Wl3JwxXNmZAgkQDvvxsb3sahzH8K PUg4NIZj8IJ+dOgqqKJR472TCK9ldhJ6gUsHcGd0lsolNKv3jSnV2wJbQE5/634M lFdgeA6dWezSyW1fFxgOdoLjkPbj+p8DeL+OL62xWNHE9ofsdScTCX+vSi/k2kw= =LN6c -----END PGP SIGNATURE----- --bde0g249v2wHScUXbMpLLPDd8nThlmnOC--