Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Aug 2012 07:50:32 GMT
From:      Thomas Zander <thomas.e.zander@googlemail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/170730: [pkgng] mplayer-skins plist generation
Message-ID:  <201208180750.q7I7oWba063006@red.freebsd.org>
Resent-Message-ID: <201208180800.q7I80QEM098649@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         170730
>Category:       ports
>Synopsis:       [pkgng] mplayer-skins plist generation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 18 08:00:25 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Thomas Zander
>Release:        FreeBSD 9.1-PRERELEASE
>Organization:
>Environment:
>Description:
I received via pm a suggestion to fix the mplayer-skin port for pkgng.
Apparently the problem is that pkgng picks up its metadata dir when doing a reinstall.
>How-To-Repeat:

>Fix:
The attached patch is supposed to fix the problem.
Could someone from the pkgng team please check whether this is the recommended way to deal with the issue? Thanks.

Patch attached with submission follows:

diff -ruN /usr/ports/multimedia/mplayer-skins/Makefile mplayer-skins/Makefile
--- /usr/ports/multimedia/mplayer-skins/Makefile	2012-01-11 20:16:58.000000000 +0100
+++ mplayer-skins/Makefile	2012-08-18 09:32:13.722445544 +0200
@@ -72,8 +72,8 @@
 .endif
 
 do-install:
-# both anotate and create target directories
-	@for dir in `cd ${WRKDIR} && ${FIND} . -type d ! -name ".*" | ${SORT} -r` ; do \
+# anotate and create target directories
+	@for dir in `cd ${WRKDIR} && ${FIND} ./* -type d | ${SORT} -r` ; do \
 		${MKDIR} "${PREFIX}/${myDATADIR}/$${dir#./}" ; \
 		LAST_DIR="$${dir#./}"; \
 	done && \
@@ -81,8 +81,8 @@
 .ifdef(WITH_SKIN_DEFAULT)
 	@${LN} -sfh "${PREFIX}/${myDATADIR}/Blue" "${PREFIX}/${myDATADIR}/default"
 .endif
-# both anotate installed and install files
-	@for f in `cd ${WRKDIR} && ${FIND} . -type f ! -name ".*" | ${SORT}` ; do \
+# anotate installed and install files
+	@for f in `cd ${WRKDIR} && ${FIND} ./* -type f | ${SORT}` ; do \
 		${INSTALL_DATA} "${WRKDIR}/$${f#./}" ${PREFIX}/${myDATADIR}/$${f#./} ; \
 	done
 # add marker file


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208180750.q7I7oWba063006>