From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Aug 18 08:00:26 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 663381065676 for ; Sat, 18 Aug 2012 08:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3EECC8FC16 for ; Sat, 18 Aug 2012 08:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7I80QCR098650 for ; Sat, 18 Aug 2012 08:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7I80QEM098649; Sat, 18 Aug 2012 08:00:26 GMT (envelope-from gnats) Resent-Date: Sat, 18 Aug 2012 08:00:26 GMT Resent-Message-Id: <201208180800.q7I80QEM098649@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Zander Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F4089106566C for ; Sat, 18 Aug 2012 07:50:32 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id DF5368FC14 for ; Sat, 18 Aug 2012 07:50:32 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7I7oWf5063007 for ; Sat, 18 Aug 2012 07:50:32 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7I7oWba063006; Sat, 18 Aug 2012 07:50:32 GMT (envelope-from nobody) Message-Id: <201208180750.q7I7oWba063006@red.freebsd.org> Date: Sat, 18 Aug 2012 07:50:32 GMT From: Thomas Zander To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/170730: [pkgng] mplayer-skins plist generation X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Aug 2012 08:00:26 -0000 >Number: 170730 >Category: ports >Synopsis: [pkgng] mplayer-skins plist generation >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sat Aug 18 08:00:25 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Thomas Zander >Release: FreeBSD 9.1-PRERELEASE >Organization: >Environment: >Description: I received via pm a suggestion to fix the mplayer-skin port for pkgng. Apparently the problem is that pkgng picks up its metadata dir when doing a reinstall. >How-To-Repeat: >Fix: The attached patch is supposed to fix the problem. Could someone from the pkgng team please check whether this is the recommended way to deal with the issue? Thanks. Patch attached with submission follows: diff -ruN /usr/ports/multimedia/mplayer-skins/Makefile mplayer-skins/Makefile --- /usr/ports/multimedia/mplayer-skins/Makefile 2012-01-11 20:16:58.000000000 +0100 +++ mplayer-skins/Makefile 2012-08-18 09:32:13.722445544 +0200 @@ -72,8 +72,8 @@ .endif do-install: -# both anotate and create target directories - @for dir in `cd ${WRKDIR} && ${FIND} . -type d ! -name ".*" | ${SORT} -r` ; do \ +# anotate and create target directories + @for dir in `cd ${WRKDIR} && ${FIND} ./* -type d | ${SORT} -r` ; do \ ${MKDIR} "${PREFIX}/${myDATADIR}/$${dir#./}" ; \ LAST_DIR="$${dir#./}"; \ done && \ @@ -81,8 +81,8 @@ .ifdef(WITH_SKIN_DEFAULT) @${LN} -sfh "${PREFIX}/${myDATADIR}/Blue" "${PREFIX}/${myDATADIR}/default" .endif -# both anotate installed and install files - @for f in `cd ${WRKDIR} && ${FIND} . -type f ! -name ".*" | ${SORT}` ; do \ +# anotate installed and install files + @for f in `cd ${WRKDIR} && ${FIND} ./* -type f | ${SORT}` ; do \ ${INSTALL_DATA} "${WRKDIR}/$${f#./}" ${PREFIX}/${myDATADIR}/$${f#./} ; \ done # add marker file >Release-Note: >Audit-Trail: >Unformatted: