From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Aug 10 06:50:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BD178C75 for ; Sat, 10 Aug 2013 06:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C6102B8E for ; Sat, 10 Aug 2013 06:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7A6o0JF012013 for ; Sat, 10 Aug 2013 06:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7A6o0d0012012; Sat, 10 Aug 2013 06:50:00 GMT (envelope-from gnats) Resent-Date: Sat, 10 Aug 2013 06:50:00 GMT Resent-Message-Id: <201308100650.r7A6o0d0012012@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anton Afanasyev Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 11A0EAD2 for ; Sat, 10 Aug 2013 06:40:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F2E052B37 for ; Sat, 10 Aug 2013 06:40:14 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7A6eEs0083261 for ; Sat, 10 Aug 2013 06:40:14 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7A6eEBt083256; Sat, 10 Aug 2013 06:40:14 GMT (envelope-from nobody) Message-Id: <201308100640.r7A6eEBt083256@oldred.freebsd.org> Date: Sat, 10 Aug 2013 06:40:14 GMT From: Anton Afanasyev To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/181198: devel/ncurses-devel does not build because of an inconsistency of patch and the patch files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 06:50:00 -0000 >Number: 181198 >Category: ports >Synopsis: devel/ncurses-devel does not build because of an inconsistency of patch and the patch files >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Aug 10 06:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Anton Afanasyev >Release: 9.2-BETA2 x64 >Organization: >Environment: FreeBSD MACHINENAME 9.2-BETA2 FreeBSD 9.2-BETA2 #0 r253720: Sat Jul 27 16:50:40 PDT 2013 root@worldmaker:/usr/obj/usr/src/sys/KERNNAME amd64 >Description: File "test/background.c" #includes "color_name.h", which is located in the parent directory of the directory "test" (can be seen by running make build in the port directory, and then browsing the work directory). It should actually be in the "test" directory, as per the patch file that added it (ncurses-5.9-20110423). >How-To-Repeat: This started happening since PR 180821, which was in turn an attempt at fixing the switch to the BSD-licensed patch (as per its description). I have not tried this on any other releases of FreeBSD. >Fix: A quick analysis shows that the BSD-licensed patch also strips path segments of added files, resulting in files being added in wrong directories. For example, the "ncurses-5.9-20110423" patch adds a "./test/color_name.h" file (clearly to the "test" directory). But the new patch places it into the parent of "test", resulting in the build problem described. It sounds like either a fix for BSD patch is needed, or this port should be patched to have "test/background.c" include "../color_name.h" instead of "color_name.h". I've attached the patch for the latter, but it feels like a crutch to me, hence the suggesion to fix the BSD patch. Patch attached with submission follows: --- test/background.c.orig +++ test/background.c @@ -31,7 +31,7 @@ #define NEED_COLOR_CODE 1 #define NEED_COLOR_NAME 1 -#include +#include <../color_name.h> static int default_bg = COLOR_BLACK; static int default_fg = COLOR_WHITE; >Release-Note: >Audit-Trail: >Unformatted: