From owner-cvs-all@FreeBSD.ORG Fri Jun 11 03:40:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 627A916A4D0; Fri, 11 Jun 2004 03:40:49 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0F9043D1D; Fri, 11 Jun 2004 03:40:48 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i5B3em2n009934; Thu, 10 Jun 2004 23:40:48 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i5B3emZZ009933; Thu, 10 Jun 2004 23:40:48 -0400 (EDT) Date: Thu, 10 Jun 2004 23:40:48 -0400 From: Ken Smith To: Ken Smith Message-ID: <20040611034048.GE8579@electra.cse.Buffalo.EDU> References: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406110334.i5B3Y2xH090581@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 03:40:49 -0000 On Fri, Jun 11, 2004 at 03:34:02AM +0000, Ken Smith wrote: > kensmith 2004-06-11 03:34:02 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdtime localtime.c > Log: > Change defualt time zone from GMT to UTC. This will not be MFC-ed, and > was done before 5-STABLE on purpose... > > Revision Changes Path > 1.38 +6 -1 src/lib/libc/stdtime/localtime.c In my warning message sent to current@ saying this was in the works I had asked for thoughts on whether or not to "clean up" the code, more or less doing "s/gmt/utc/g". Those who sent in thoughts were divided roughly half in favor, half against. I couldn't decide if the cleanliness was worth the size of the diff so I did my usual thing when confused about cleanliness and/or style issues - I asked bde@. :-) Bruce pointed out several things but the kicker was that this code originally came from an import from a vendor branch. We import the time zone data from that source fairly frequently. We import the time zone code far less frequently. But a gratuitous sweep through changing lots of variable/function names would make future code imports unnecessarily harder. So I'll leave it as-is. Thanks again Bruce. :-) -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |