From owner-svn-src-all@freebsd.org Fri Aug 7 15:51:39 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 09FF93BDBDD; Fri, 7 Aug 2020 15:51:39 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNVGK0hPSz4ZMj; Fri, 7 Aug 2020 15:51:36 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1596815495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SNS/9qO2ProL4Zc4ua394pTE1hocjCRID6/XmvAcuzg=; b=Vd85g3io6HMArXW2MFYrOJHgKUJXeARqp++v3SVSSmdG/ZLgjf8B7Tm9lESvQsEQUCIuaL QsUCkzyhIDeisWM7SfqiAUQcTo5YZRhT0bTMIvAiLaoZPFFdmem4C78SZP5Q2Xwp9e8JXC J1NfB59kZl2GAEf2az1XQCk2ekbQXa4= Received: from amy.home (lfbn-idf2-1-1138-237.w90-92.abo.wanadoo.fr [90.92.20.237]) by mx.blih.net (OpenSMTPD) with ESMTPSA id f627b2ad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 7 Aug 2020 15:51:35 +0000 (UTC) Date: Fri, 7 Aug 2020 17:51:35 +0200 From: Emmanuel Vadot To: Ian Lepore Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364010 - head/sbin/iscontrol Message-Id: <20200807175135.077394491bcb290739fe2655@bidouilliste.com> In-Reply-To: <5456249cc4128924a57729905b561ad39bc8663e.camel@freebsd.org> References: <202008071219.077CJLbH085411@repo.freebsd.org> <202008071526.077FQ0uQ017440@gndrsh.dnsmgr.net> <20200807173214.0f831da5ab649eec811b2466@bidouilliste.com> <5456249cc4128924a57729905b561ad39bc8663e.camel@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BNVGK0hPSz4ZMj X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=Vd85g3io; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.04 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.983]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-0.56)[-0.558]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 15:51:39 -0000 On Fri, 07 Aug 2020 09:45:05 -0600 Ian Lepore wrote: > On Fri, 2020-08-07 at 17:32 +0200, Emmanuel Vadot wrote: > > On Fri, 7 Aug 2020 08:26:00 -0700 (PDT) > > "Rodney W. Grimes" wrote: > > > > > > Author: manu > > > > Date: Fri Aug 7 12:19:21 2020 > > > > New Revision: 364010 > > > > URL: https://svnweb.freebsd.org/changeset/base/364010 > > > > > > > > Log: > > > > pkgbase: We can't easily have a package with either a - or a _ > > > > > > Wow, hopefully this is short term. > > > > Not really. > > > > > I would think a package name can be any valid file name, and to > > > remove - and _ from that set is going > > > to cause lots of POLA. > > > > The package file itself contain '-', they are named > > FreeBSD--{dbg,lib32,dev,}-. it's just that we used - > > and > > _ when building them to get some variable which contain the > > description, nothing that can't be patched by this is clearly not my > > priority. > > > > This should be easy to fix. Use sed instead of tr, and translate - to > __ to remove dashes, and then translate __ back to - to restore them, > and you've properly preserved single _ usage in names. > > -- Ian > Yes it's easy to fix but that would required renaming the variables in release/packages/Makefile.packages and since I don't like how this part of pkgbase is done right now I prefer to not touch this part for now otherwise I would rewrite everything. There is more urgent work to be done. > > > > > > > > > > > Rename iscsi_legacy to iscsilegacy, having - or _ in a package > > > > name cause > > > > problems when we process them and generate the ucl. > > > > > > > > Modified: > > > > head/sbin/iscontrol/Makefile > > > > > > > > Modified: head/sbin/iscontrol/Makefile > > > > ================================================================= > > > > ============= > > > > --- head/sbin/iscontrol/Makefile Fri Aug 7 10:20:39 2020 ( > > > > r364009) > > > > +++ head/sbin/iscontrol/Makefile Fri Aug 7 12:19:21 2020 ( > > > > r364010) > > > > @@ -1,6 +1,6 @@ > > > > # $FreeBSD$ > > > > > > > > -PACKAGE=iscsi_legacy > > > > +PACKAGE=iscsilegacy > > > > SRCS= iscontrol.c pdu.c fsm.c config.c login.c auth_subr.c > > > > misc.c > > > > PROG= iscontrol > > > > LIBADD= cam md > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- Emmanuel Vadot