From owner-cvs-src@FreeBSD.ORG Mon May 7 18:45:20 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0647C16A406; Mon, 7 May 2007 18:45:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 7A43913C458; Mon, 7 May 2007 18:45:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l47IjGQv076569; Mon, 7 May 2007 14:45:17 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Paolo Pisati Date: Mon, 7 May 2007 13:53:59 -0400 User-Agent: KMail/1.9.6 References: <200705061702.l46H2oVK057260@repoman.freebsd.org> <20070506174426.GO17958@funkthat.com> <20070506191027.GA2050@tin.it> In-Reply-To: <20070506191027.GA2050@tin.it> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705071354.00455.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 07 May 2007 14:45:17 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3216/Mon May 7 03:36:02 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, John-Mark Gurney , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/i386/i386 intr_machdep.c src/sys/kern kern_intr.c src/sys/sys interrupt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2007 18:45:20 -0000 On Sunday 06 May 2007 03:10:27 pm Paolo Pisati wrote: > On Sun, May 06, 2007 at 10:44:26AM -0700, John-Mark Gurney wrote: > > Paolo Pisati wrote this message on Sun, May 06, 2007 at 17:02 +0000: > > > Modified files: > > > sys/amd64/amd64 intr_machdep.c > > > sys/i386/i386 intr_machdep.c > > > sys/kern kern_intr.c > > > sys/sys interrupt.h > > > Log: > > > Bring in the reminaing bits to make interrupt filtering work: > > > > When are we going to see man page updates to document this new feature? > > didn't prepare any patch for man pages cause the support for some > archs is still missing, but i can do that if requested. > > > Also, you forgot to update sys/sys/bus.h's comments? or did you fix > > the code to behave like the comments? > > you mean this comment: > > --------8<--------8<--------8<--------8<--------8<--------8<-------- > > /** > * @brief Driver interrupt filter return values > * > * If a driver provides an interrupt filter routine it must return an > * integer consisting of oring together zero or more of the following > * flags: > * > * FILTER_STRAY - this device did not trigger the interrupt > * FILTER_HANDLED - the interrupt has been fully handled and can be EOId > * FILTER_SCHEDULE_THREAD - the threaded interrupt handler should be > * scheduled to execute > * > * If the driver does not provide a filter, then the interrupt code will > * act is if the filter had returned FILTER_SCHEDULE_THREAD. Note that it > * is illegal to specify any other flag with FILTER_STRAY and that it is > * illegal to not specify either of FILTER_HANDLED or FILTER_SCHEDULE_THREAD > * if FILTER_STRAY is not specified. > */ > #define FILTER_STRAY 0x01 > #define FILTER_HANDLED 0x02 > #define FILTER_SCHEDULE_THREAD 0x04 My suggestion on this a while back btw was to convert this from a bitmask to an "enum" and have FILTER_SCHEDULE_THREAD be 3 and imply FILTER_HANDLED, and filters return 1 of the 3 values. -- John Baldwin