From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 30 21:40:11 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D806B1065694 for ; Sat, 30 Oct 2010 21:40:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6A4A98FC0A for ; Sat, 30 Oct 2010 21:40:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9ULeBFC000607 for ; Sat, 30 Oct 2010 21:40:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9ULeB1g000606; Sat, 30 Oct 2010 21:40:11 GMT (envelope-from gnats) Resent-Date: Sat, 30 Oct 2010 21:40:11 GMT Resent-Message-Id: <201010302140.o9ULeB1g000606@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Toomas Aas Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37A311065672 for ; Sat, 30 Oct 2010 21:35:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 1F2A68FC0C for ; Sat, 30 Oct 2010 21:35:05 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9ULZ4am072573 for ; Sat, 30 Oct 2010 21:35:04 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o9ULZ3Rs072572; Sat, 30 Oct 2010 21:35:03 GMT (envelope-from nobody) Message-Id: <201010302135.o9ULZ3Rs072572@www.freebsd.org> Date: Sat, 30 Oct 2010 21:35:03 GMT From: Toomas Aas To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/151840: www/ruby-cruisecontrolrb rc.d script doesn't clean up on stop X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2010 21:40:11 -0000 >Number: 151840 >Category: ports >Synopsis: www/ruby-cruisecontrolrb rc.d script doesn't clean up on stop >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Oct 30 21:40:11 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Toomas Aas >Release: 8.1-RELEASE-p1 >Organization: >Environment: FreeBSD builder.tarkvarastuudio.ee 8.1-RELEASE-p1 FreeBSD 8.1-RELEASE-p1 #1: Tue Sep 21 23:49:01 EEST 2010 toomas@builder.tarkvarastuudio.ee:/usr/obj/usr/src/sys/TVS8 amd64 >Description: The script /usr/local/etc/rc.d/cruisecontrolrb doesn't shut down builder processes when run with the 'stop' argument. Since the PID files of the builders are also left behind, this means that cruisecontrol.rb will not start automatically on server reboot. >How-To-Repeat: Configure some projects in cruisecontrol.rb Start the dashboard and builders: /usr/local/etc/rc.d/cruisecontrolrb start Now run: /usr/local/etc/rc.d/cruisecontrolrb stop And then again: /usr/local/etc/rc.d/cruisecontrolrb start Notice that cruisecontrol.rb was not started. >Fix: Attached is a patch to the rc.d script, which terminates the builders and removes their PID files when run with the 'stop' argument. Patch attached with submission follows: a30 7 cd %%PREFIX%%/www/${name}/tmp/pids/builders/ for builder in `ls` do { kill $(cat $builder) rm ${builder} } done >Release-Note: >Audit-Trail: >Unformatted: