Date: Mon, 22 Jan 2018 14:56:43 +0000 From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 222905] x11/libinput: Update to 1.9.1 Message-ID: <bug-222905-7141-6UAOnufWmc@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-222905-7141@https.bugs.freebsd.org/bugzilla/> References: <bug-222905-7141@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222905 Greg V <greg@unrelenting.technology> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187854|0 |1 is obsolete| | --- Comment #6 from Greg V <greg@unrelenting.technology> --- Created attachment 189969 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189969&action=edit libinput-1.9.901.patch Update to 1.9.901 + add a new 'reopen' patch… So, here's the story about that patch. I'm working on Wayland compositor stuff (https://github.com/myfreeweb/weston-rs + https://github.com/myfreeweb/loginw). I've been trying to figure out why in the heck does *only my compositor* (not Weston proper) reject input devices *only on my laptop* (not on my desktop)… /dev/input devices were readable and writable for group video. My setuid wrapper (loginw) was only setting the user when dropping privileges for the compositor (i.e. wasn't setting groups). I was testing unprivileged access, but I thought I was still testing privileged access. Anyway, it is very desirable to have the compositor unprivileged. The setuid wrapper passes it file descriptors to input devices, it does not need to open them directly. libudev-devd does open them — to enumerate devices. When it is unprivileged, it does not set the right properties, which leads to rejection (the "not tagged as supported input device" message). libinput opens the device via the compositor-provided mechanism (fd passing) only to compare to the device it got from libudev(-devd) enumeration. They have the same path, but the libudev one lacks properties. The correct one gets thrown away. This patch uses the correct one instead of throwing it away :) which allows compositors to be unprivileged. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222905-7141-6UAOnufWmc>