From nobody Mon Oct 11 18:01:11 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0446E180169F; Mon, 11 Oct 2021 18:01:18 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HSmnT6SV9z4vkN; Mon, 11 Oct 2021 18:01:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82e.google.com with SMTP id b12so9127363qtq.3; Mon, 11 Oct 2021 11:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GZrfd6LECEc549IRwphhuOVM5MoTiMUqBCy86+5AsvM=; b=QSW3qzM2jP9kArNFU83cNF9SpyAqaW7YYjihRUeR2zQ1Xg25OHeqsax82N+djYRTXT Qb77BO2dC+5mZTy7x8kQNGYz9OZmwYSdnLnRvKc+nQ3DSAcDzJy0vq07aS3d4f0NL7BW xQNFuiBGL896eWjopAsPby6SwKbsqtxXk53Oe4ZyJPCrTA1D2fEOi1O1oAM22J5NFcGA tTzawapel95ku9AmgF5ApnS/8fqBJE5oV1mjOFIfZUoHgoFsdkCtQ2TzXZ1hzTG9oGih TSCmk0Q0i1zb4cDT4mShOHfzeDkjl0FQ1KCxo/Hs70nYVEQMZctjxomMrhb/Wd4wghA2 wwOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=GZrfd6LECEc549IRwphhuOVM5MoTiMUqBCy86+5AsvM=; b=fX4w5EY6wlE8CsUnMw/h2c5biJq20COA3Kykpl7OWKXX6LHS831tUwddW6QxUHl0lM OrrCI6Zabxoo8h4j6nR3aFQF6YDL0HdoLRp4siMtJSTK3n6LCUeC8S4i92FgIjigoaVi m0m9lBvbgSRJ4LatXhIvB/Jyas/r43/kWwDkgSkZlhVL3CSzv+4UD8PevqWoEtPadgJC peSD9fi4rxjMMKMBJASNpiwVAsljdQEtNTYH3sW7N++kEQe9YB6qgnNjjBd040/wJybn 56GmkCnmgtKka7ICLbP4RqQhx//8w88txx1kdF6b+pZdjEtsTux0QXxDfrQM9PlS8DRO zw6w== X-Gm-Message-State: AOAM533tEImWOJrQk+afqWT3TkIwH/4lTmgTOIXCXlZkE9BoVUBer0nP JBAJXzj2Uqbdl8nVtEDTvI9Q/euMrxE= X-Google-Smtp-Source: ABdhPJx/OC6LEMPAERERRXI55DNB3p89Sr2MW0t3vw8V0GdTIkZA/HxIC4gSfEsp6MG8vKfZ1VG7sQ== X-Received: by 2002:ac8:5c44:: with SMTP id j4mr16022755qtj.164.1633975277264; Mon, 11 Oct 2021 11:01:17 -0700 (PDT) Received: from nuc ([142.126.186.191]) by smtp.gmail.com with ESMTPSA id l20sm5177545qtk.19.2021.10.11.11.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 11:01:16 -0700 (PDT) Sender: Mark Johnston Date: Mon, 11 Oct 2021 14:01:11 -0400 From: Mark Johnston To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c05b382edb17 - main - Revert "bootstrap: No need to disable shared libraries for bootstrap tools" Message-ID: References: <202110111754.19BHsOls003350@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202110111754.19BHsOls003350@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4HSmnT6SV9z4vkN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Oct 11, 2021 at 05:54:24PM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c05b382edb173d199ddef86976d594fbbb7bbf24 > > commit c05b382edb173d199ddef86976d594fbbb7bbf24 > Author: Warner Losh > AuthorDate: 2021-10-11 17:49:48 +0000 > Commit: Warner Losh > CommitDate: 2021-10-11 17:49:48 +0000 > > Revert "bootstrap: No need to disable shared libraries for bootstrap tools" > > This reverts commit e8f26e5dc859a8fbc663e108421f657325ca3054. > > Although the change worked locally, it's breaking something in the CI > build for the riscv64 build (which makes no sense it would only break > that since we're building host tools to bootstrap at that point). This also seems to have broken syzbot's FreeBSD CI builds, which run "make kernel-toolchain -DNO_CLEAN" before building a kernel: https://syzkaller.appspot.com/text?tag=CrashLog&x=10b4cb98b00000 I wasn't sure if the reverted commit might be tripped up by -DNO_CLEAN, so I was about to submit a syzkaller change to automatically try a clean build after a failing -DNO_CLEAN build. The build host is also quite old, running some stable/12 revision from a couple of years ago. > Sponsored by: Netflix > --- > Makefile.inc1 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index fb640eefdb82..9b81d4029608 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -720,6 +720,7 @@ BSARGS= DESTDIR= \ > -DNO_CPU_CFLAGS \ > -DNO_LINT \ > -DNO_PIC \ > + -DNO_SHARED \ > MK_ASAN=no \ > MK_CTF=no \ > MK_CLANG_EXTRAS=no \