Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Oct 2017 19:19:22 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Ian Lepore <ian@FreeBSD.org>
Cc:        Andriy Gapon <avg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r324163 - in head: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool cddl/contrib/opensolaris/lib/libzfs/common cddl/contrib/opensolaris/lib/libzfs_core/common cddl/co...
Message-ID:  <76C2AE49-9202-4187-A23C-3110F08EBBD5@FreeBSD.org>
In-Reply-To: <1506877870.22078.28.camel@freebsd.org>
References:  <201710011611.v91GB8LM024101@repo.freebsd.org> <1506877870.22078.28.camel@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_2AEC4A16-8414-456C-AC62-2CFAFF92FE2A
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 1 Oct 2017, at 19:11, Ian Lepore <ian@FreeBSD.org> wrote:
> 
> On Sun, 2017-10-01 at 16:11 +0000, Andriy Gapon wrote:
>> Author: avg
>> Date: Sun Oct  1 16:11:07 2017
>> New Revision: 324163
>> URL: https://svnweb.freebsd.org/changeset/base/324163
>> 
>> Log:
>>   MFV r323530,r323533,r323534: 7431 ZFS Channel Programs, and
>> followups
>> 
> 
> Powerpc and sparc builds are dying on:
> 
> src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c:870:
> warning: comparison is always true due to limited range of data type
> 
> "(unsigned char)anything >= 0" is also always true on clang, so I'm not
> sure why it doesn't warn too.

We've been using the clang-specific flag -Wno-error-tautological-compare
since some time, so it warns, but doesn't error out on it.  Fixing all
the occurrences in the kernel was too disruptive at the time.

-Dimitry


--Apple-Mail=_2AEC4A16-8414-456C-AC62-2CFAFF92FE2A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWdEjmgAKCRCwXqMKLiCW
o4LgAJ9V8lLjg9l4rSHy4iY++465xbdb5gCdG2oCsghZyr0N+fFaKAuhtTlq5qg=
=kLU5
-----END PGP SIGNATURE-----

--Apple-Mail=_2AEC4A16-8414-456C-AC62-2CFAFF92FE2A--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76C2AE49-9202-4187-A23C-3110F08EBBD5>