From owner-p4-projects@FreeBSD.ORG Mon Nov 24 17:40:11 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 51A321065834; Mon, 24 Nov 2008 17:40:11 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A39F61065762 for ; Mon, 24 Nov 2008 17:40:10 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5665F8FC14 for ; Mon, 24 Nov 2008 17:40:04 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mAOHe49i044439 for ; Mon, 24 Nov 2008 17:40:04 GMT (envelope-from sam@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mAOHe4X5044437 for perforce@freebsd.org; Mon, 24 Nov 2008 17:40:04 GMT (envelope-from sam@freebsd.org) Date: Mon, 24 Nov 2008 17:40:04 GMT Message-Id: <200811241740.mAOHe4X5044437@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to sam@freebsd.org using -f From: Sam Leffler To: Perforce Change Reviews Cc: Subject: PERFORCE change 153447 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2008 17:40:11 -0000 http://perforce.freebsd.org/chv.cgi?CH=153447 Change 153447 by sam@sam_ebb on 2008/11/24 17:39:57 o move check to where it's needed o style Affected files ... .. //depot/projects/arp-v2/src/sys/netinet/if_ether.c#17 edit Differences ... ==== //depot/projects/arp-v2/src/sys/netinet/if_ether.c#17 (text+ko) ==== @@ -198,10 +198,10 @@ SIN(ifa->ifa_netmask)->sin_addr.s_addr) ) break; /* found it. */ } - } - if (sip == NULL) { - printf(" cannot find matching address, no arprequest\n"); - return; + if (sip == NULL) { + printf("%s: cannot find matching address\n", __func__); + return; + } } if ((m = m_gethdr(M_DONTWAIT, MT_DATA)) == NULL) @@ -226,8 +226,6 @@ sa.sa_len = 2; m->m_flags |= M_BCAST; (*ifp->if_output)(ifp, m, &sa, (struct rtentry *)0); - - return; } /* @@ -255,7 +253,7 @@ *lle = NULL; - if (m) { + if (m != NULL) { if (m->m_flags & M_BCAST) { /* broadcast */ (void)memcpy(desten,