From owner-p4-projects@FreeBSD.ORG  Fri Apr 21 21:13:54 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DF6E416A401; Fri, 21 Apr 2006 21:13:53 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7B10216A403
	for <perforce@freebsd.org>; Fri, 21 Apr 2006 21:13:53 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D323543D45
	for <perforce@freebsd.org>; Fri, 21 Apr 2006 21:13:52 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3LLDqP2094303
	for <perforce@freebsd.org>; Fri, 21 Apr 2006 21:13:52 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3LLDq6n094290
	for perforce@freebsd.org; Fri, 21 Apr 2006 21:13:52 GMT
	(envelope-from imp@freebsd.org)
Date: Fri, 21 Apr 2006 21:13:52 GMT
Message-Id: <200604212113.k3LLDq6n094290@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 95827 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Apr 2006 21:13:54 -0000

http://perforce.freebsd.org/chv.cgi?CH=95827

Change 95827 by imp@imp_hammer on 2006/04/21 21:13:17

	Apply SWAP16 to constants rather than non-constants.  This saves
	another 70ish bytes

Affected files ...

.. //depot/projects/arm/src/sys/boot/arm/at91/libat91/emac.c#8 edit

Differences ...

==== //depot/projects/arm/src/sys/boot/arm/at91/libat91/emac.c#8 (text+ko) ====

@@ -147,7 +147,7 @@
 
 	udpHdr = (udp_header_t*)(ipHdr + 1);
 
-	udpHdr->src_port  = SWAP16(localPort);
+	udpHdr->src_port  = localPort;
 	udpHdr->dst_port  = serverPort;
 	udpHdr->udp_len   = SWAP16(8 + tftpLength);
 	udpHdr->udp_cksum = 0;
@@ -324,14 +324,14 @@
 			udpHdr = (udp_header_t*)((char*)pIpHeader+20);
 			tftpHdr = (tftp_header_t*)((char*)udpHdr + 8);
 
-			if (SWAP16(udpHdr->dst_port) != localPort)
+			if (udpHdr->dst_port != localPort)
 				break;
 
-			if (SWAP16(tftpHdr->opcode) != TFTP_DATA_OPCODE)
+			if (tftpHdr->opcode != SWAP16(TFTP_DATA_OPCODE))
 				break;
 
 			if (ackBlock == -1) {
-				if (SWAP16(tftpHdr->block_num) != 1)
+				if (tftpHdr->block_num != SWAP16(1))
 					break;
 				serverPort = udpHdr->src_port;
 				ackBlock = 0;
@@ -667,7 +667,7 @@
 	serverMACSet = 0;
 	localIPSet = 0;
 	serverIPSet = 0;
-	localPort = 0x8002;
+	localPort = SWAP16(0x8002);
 	lastAddress = 0;
 	lastSize = 0;
 	MAC_init = 0;