From owner-svn-ports-head@FreeBSD.ORG  Fri Feb  1 00:36:14 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 22214DA0
 for <svn-ports-head@freebsd.org>; Fri,  1 Feb 2013 00:36:14 +0000 (UTC)
 (envelope-from timur@bat.ru)
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by mx1.freebsd.org (Postfix) with ESMTP id A8662DFB
 for <svn-ports-head@freebsd.org>; Fri,  1 Feb 2013 00:36:13 +0000 (UTC)
Received: by mail-wi0-f174.google.com with SMTP id hj13so48846wib.7
 for <svn-ports-head@freebsd.org>; Thu, 31 Jan 2013 16:36:12 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=x-received:mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type
 :x-gm-message-state;
 bh=j2YU0eXcDjnssO5yST21VorWFCgSskrGWdecCRFhUzE=;
 b=PfacG51g5dtaRPgX28SeNFdaF43cbOJlrnUIf0tGp3oBrVlUlpJrTtea8GS8k6W7Aa
 kdf7ENL9U46lg+qf5i+lGiyEbtHU1eJYZx1Q+8wgbxGtbMcfVsXMCTW5RH1gTz4u9cUy
 xxELNTtA4EPzRPoCMpmBHRwVmLMP1G7pnAjC+Be1vqlEEXALNum9+14l1sFzJhyP447j
 W2W12xoFrCbpyhizSf84WTQOZD53bPWM8/EVa4c1aUZvn2dYrccgtoP6SNqTkmnkcnbZ
 6XLZnv//k7you3Z3om7rzbSkytOQPwqbHPGShckWhvDgCAI9/t4mztJa6rAh7cnsn4vC
 EkWQ==
X-Received: by 10.194.20.231 with SMTP id q7mr18557682wje.44.1359678972543;
 Thu, 31 Jan 2013 16:36:12 -0800 (PST)
MIME-Version: 1.0
Sender: timur@bat.ru
Received: by 10.194.152.74 with HTTP; Thu, 31 Jan 2013 16:35:52 -0800 (PST)
In-Reply-To: <CAF6rxgkXjA7u7d=sasC=qBpObvDobH5BQL3eOCEXxFT0RpP6Kw@mail.gmail.com>
References: <201301311914.r0VJE8R8091684@svn.freebsd.org>
 <510ACB0F.9040402@FreeBSD.org>
 <CAF6rxgkXjA7u7d=sasC=qBpObvDobH5BQL3eOCEXxFT0RpP6Kw@mail.gmail.com>
From: "Timur I. Bakeyev" <timur@FreeBSD.org>
Date: Fri, 1 Feb 2013 01:35:52 +0100
X-Google-Sender-Auth: jTEIqIXetnA37s0w061y89bsFGQ
Message-ID: <CALdFvJEaFr_3C3yspJeA7SnoJQpfrqRiq8oO_-Aep3UnySHnbQ@mail.gmail.com>
Subject: Re: svn commit: r311324 - in head: . misc/amanda-server
 misc/amanda25-server misc/amanda26-server misc/amanda32-server
 misc/instant-server net-im/kpopup net-im/linpopup net/jags net/lanbrowsing
 net/pro...
To: Eitan Adler <eadler@freebsd.org>
X-Gm-Message-State: ALoCoQlY7LdZM3/Gvn91ophXx6ISfDMBZ2bYQ1ygAPJrehihaT72mN3hoCYZZnwhhH1QC7YKAKtv
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Bryan Drewery <bdrewery@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2013 00:36:14 -0000

Sorry, forgot to mention that fix, did it almost automatically...


On Fri, Feb 1, 2013 at 12:34 AM, Eitan Adler <eadler@freebsd.org> wrote:

> On 31 January 2013 14:50, Bryan Drewery <bdrewery@freebsd.org> wrote:
> > On 1/31/2013 1:14 PM, Timur I. Bakeyev wrote:
> >>  .if defined (WITH_SAMBA)
> >> -SAMBA_PORT?= samba34
> >> +SAMBA_PORT?= samba36
> >>  BUILD_DEPENDS+=      smbclient:${PORTSDIR}/net/${SAMBA_PORT}
> >>  RUN_DEPENDS+=        smbclient:${PORTSDIR}/net/${SAMBA_PORT}
> >> -CONFIGURE_ARGS+=     --with-smbclient=${PREFIX}/bin/smbclient
> >> +CONFIGURE_ARGS+=     --with-smbclient=${LOCALBASE}/bin/smbclient
> >
> > Shouldn't PREFIX be respected and LOCALBASE just the default?
>
> This diff is correct.  PREFIX is where samba will be installed to.
> LOCALBASE refers to where things are already installed.   In this case
> smbclient is a build and run depend, which means is already installed
> (and therefore in LOCALBASE).
>
> I wish the commit log were more clear.
>
> --
> Eitan Adler
> Source, Ports, Doc committer
> Bugmeister, Ports Security teams
>