From owner-svn-ports-head@freebsd.org  Tue Jan 29 15:05:29 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7B0614C03F4;
 Tue, 29 Jan 2019 15:05:28 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E4798A5EB;
 Tue, 29 Jan 2019 15:05:28 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 5B3F3138D9; Tue, 29 Jan 2019 15:05:28 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: John Hixson <jhixson@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r491567 - in head/net: . py-ifaddr
References: <201901291452.x0TEq8I7021248@repo.freebsd.org>
Date: Tue, 29 Jan 2019 16:05:25 +0100
In-Reply-To: <201901291452.x0TEq8I7021248@repo.freebsd.org> (John Hixson's
 message of "Tue, 29 Jan 2019 14:52:08 +0000 (UTC)")
Message-ID: <4l9r-ec7e-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 8E4798A5EB
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.89 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.98)[-0.983,0];
 NEURAL_HAM_LONG(-1.00)[-0.998,0];
 NEURAL_HAM_SHORT(-0.91)[-0.907,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2019 15:05:29 -0000

John Hixson <jhixson@FreeBSD.org> writes:

> +LICENSE=	MIT

MIT text has many styles[1], so there's no copy under Templates/Licenses/.
Consider defining LICENSE_FILE=${WRKSRC}/LICENSE.txt

[1] https://fedoraproject.org/wiki/Licensing:MIT

> +USES=		python:2.7+

python < 2.7 isn't supported in FreeBSD Ports since 2014-01-13. ;)

> +.if ${PYTHON_MAJOR_VER} < 3
> +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress
> +.endif

$ portlint -C
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
WARN: Makefile: you may want directory for dependency ${PYTHON_PKGNAMEPREFIX}ipaddress>0 to be net/py-ipaddress@${PY_FLAVOR}
0 fatal errors and 2 warnings found.

Note, to fix RUN_DEPENDS replace = with +=. Using = inside a conditional
may accidentally overwrite previous value.