Date: Tue, 29 Jan 2019 16:05:25 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: John Hixson <jhixson@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491567 - in head/net: . py-ifaddr Message-ID: <4l9r-ec7e-wny@FreeBSD.org> In-Reply-To: <201901291452.x0TEq8I7021248@repo.freebsd.org> (John Hixson's message of "Tue, 29 Jan 2019 14:52:08 %2B0000 (UTC)") References: <201901291452.x0TEq8I7021248@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Hixson <jhixson@FreeBSD.org> writes:
> +LICENSE= MIT
MIT text has many styles[1], so there's no copy under Templates/Licenses/.
Consider defining LICENSE_FILE=${WRKSRC}/LICENSE.txt
[1] https://fedoraproject.org/wiki/Licensing:MIT
> +USES= python:2.7+
python < 2.7 isn't supported in FreeBSD Ports since 2014-01-13. ;)
> +.if ${PYTHON_MAJOR_VER} < 3
> +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress
> +.endif
$ portlint -C
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
WARN: Makefile: you may want directory for dependency ${PYTHON_PKGNAMEPREFIX}ipaddress>0 to be net/py-ipaddress@${PY_FLAVOR}
0 fatal errors and 2 warnings found.
Note, to fix RUN_DEPENDS replace = with +=. Using = inside a conditional
may accidentally overwrite previous value.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4l9r-ec7e-wny>