From owner-freebsd-current@FreeBSD.ORG Sun Jan 15 08:52:25 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C23E61065673 for ; Sun, 15 Jan 2012 08:52:25 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8A9468FC12 for ; Sun, 15 Jan 2012 08:52:25 +0000 (UTC) Received: by iagz16 with SMTP id z16so3014906iag.13 for ; Sun, 15 Jan 2012 00:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=TvPrt+omRg9sTtywgxHcp/lxFgqrEsLT6tNJ5Vcj+IU=; b=JGorTyOEPiwvTaMJ+M8VvBqt1aWEqgiYF/mFHcjw1FNRQOFHt9bPhdKBj/lKicKGv8 JOZCT1z5W7HJPqXxCugMVpIrkc49aHt6X7EdPV9toVIpywiY6gjW3z3ybOIupXWwFSK8 wUxwG27GjD+84jlvnlIUQB7unj7DEY/WyR088= Received: by 10.42.246.71 with SMTP id lx7mr6253120icb.54.1326617544286; Sun, 15 Jan 2012 00:52:24 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.207.7 with HTTP; Sun, 15 Jan 2012 00:51:53 -0800 (PST) In-Reply-To: <20120115021101.11615318@cox.net> References: <4F114577.30201@FreeBSD.org> <4F119C40.2080503@gwdg.de> <20120115021101.11615318@cox.net> From: Chris Rees Date: Sun, 15 Jan 2012 08:51:53 +0000 X-Google-Sender-Auth: LvqeZmye_lRrl_EcFz-Z6JNHbpo Message-ID: To: "Conrad J. Sabatier" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Subject: Re: HEADS UP: set_rcvar() removed from rc.subr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 08:52:25 -0000 On 15 January 2012 08:11, Conrad J. Sabatier wrote: > On Sat, 14 Jan 2012 15:30:15 +0000 > Chris Rees wrote: > >> On 14 January 2012 15:16, Rainer Hurling wrote: >> > On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: >> >> >> >> Howdy, >> >> >> >> Per discussion in freebsd-rc@, I have removed set_rcvar() from >> >> rc.subr. The concept of set_rcvar() was nice in theory, but the >> >> forks it creates are a drag on the startup process, which is >> >> especially noticeable on slower systems, such as embedded ones. >> >> >> >> I have no plans to MFC this change, so it should only affect users >> >> who are actually on 10-current. If you have scripts >> >> in /usr/local/etc/rc.d (which if you have ports installed you >> >> almost certainly do) ... >> >> >> >> to make the change by hand, change this: >> >> >> >> name=3Dfoo >> >> rcvar=3D`set_rcvar` >> >> >> >> to: >> >> >> >> name=3Dfoo >> >> rcvar=3Dfoo_enable >> >> >> >> I didn't bump PORTREVISIONs because the change only applies to >> >> HEAD. But all of the ports are updated, so if you can't figure out >> >> how to make the change, just reinstall it. >> >> >> >> >> >> Doug >> > >> > >> > Seems that ports-mgmt/tinderbox needs an update like this: >> > >> > files/patch-etc__rc.d__tinderd >> > >> > --- etc/rc.d/tinderd.orig =A0 =A0 =A0 2011-11-20 07:01:09.000000000 +0= 100 >> > +++ etc/rc.d/tinderd =A0 =A02012-01-14 16:07:38.000000000 +0100 >> > @@ -16,7 +16,7 @@ >> > =A0. /etc/rc.subr >> > >> > =A0name=3D"tinderd" >> > -rcvar=3D`set_rcvar` >> > +rcvar=3Dtinderd_enable >> > >> > =A0# read settings, set default values >> > =A0load_rc_config "${name}" >> > >> >> I'm in the process of fixing this upstream. >> >> Chris > > Chris, if you're working on fixing ports' rc files, here are a few > potential "gotchas" to be aware of: > > I did a little quick-and-dirty sed substitution on all of my files > under /usr/local/etc/rc.d, plugging in "$filename_enable" in place of > `set_rcvar`. =A0This works just fine for all but a few. > > Filenames containing hyphens must have underscores substituted (e.g., > avahi-daemon, etc.). > > In a few cases, the rcvar is different from the filename in other > ways. =A0The only ones I came across in my local installation were > sa-spamd (spamd_enable) and mysql-server (mysql_enable). =A0There are > bound to be others like this in ports. > > Overall, though, it was a simple matter to fix up the scripts I had > installed already. =A0If I can be of any assistance in tidying up the > ports tree, let me know. Don't thank me! http://lists.freebsd.org/pipermail/cvs-ports/2012-January/233843.html The only ones that will cause trouble are the ones provided by upstream, but a quick sed like the one in ports-mgmt/tinderbox will do the trick until upstream has finished. Chris