From owner-svn-ports-all@freebsd.org Wed Feb 20 07:35:50 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D066014E94D8; Wed, 20 Feb 2019 07:35:49 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CC81F6AFD3; Wed, 20 Feb 2019 07:35:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id wMPZgNwginBo4wMPtgMygF; Wed, 20 Feb 2019 00:35:41 -0700 X-Authority-Analysis: v=2.3 cv=J8fUEzvS c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=YxBL1-UpAAAA:8 a=CicDwg1KWsLntJcUEeQA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id ED150372; Tue, 19 Feb 2019 23:35:20 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1K7ZKwa052289; Tue, 19 Feb 2019 23:35:20 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1K7ZKCi052286; Tue, 19 Feb 2019 23:35:20 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902200735.x1K7ZKCi052286@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Tobias Kortkamp cc: Cy Schubert , Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r493407 - head/graphics/xpdf4 In-Reply-To: Message from Tobias Kortkamp of "Wed, 20 Feb 2019 08:21:05 +0100." <20190220072105.GA8896@urd.tobik.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 19 Feb 2019 23:35:20 -0800 X-CMAE-Envelope: MS4wfAgCqMBVx1kQ9uD6rMvgz03/zwBf4SfraobwkSnC5+g7sJ6jBGtJiJqLoaVEe723i7fymtloDprHOkD9HVW7SBwFLpE36KGjw0zeq0jyvmZvD935iXqa +PUG/eGl/bkXlLvOHnuhznAkfn4f/XbYmbNijd3cG8XLxQjB2pBfIiWWx/twSUmmTIi0+z0f/I0o2zc8mJnij+T8kp4gzn5LKCijqlGdUmctwe+PLSw/9Kim LJqUlZxINr3LO0I2lfmgdybeyKOVLAaQ4/YfM8sQZnJm6i3NfkQpMfgG5JwmKga6VqiqMw1Xjilch+Mq/8Nn/w== X-Rspamd-Queue-Id: CC81F6AFD3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.55 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCPT_COUNT_FIVE(0.00)[6]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.94)[-0.937,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.90)[ip: (-4.85), ipnet: 64.59.128.0/20(-2.57), asn: 6327(-2.01), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[138.136.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 07:35:50 -0000 In message <20190220072105.GA8896@urd.tobik.me>, Tobias Kortkamp writes: > > > --2fHTh5uZTiUOsy+g > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Tue, Feb 19, 2019 at 10:55:38PM -0800, Cy Schubert wrote: > > In message <20190220063422.GA18880@urd.tobik.me>, Tobias Kortkamp=20 > > writes: > > >=20 > > > > > > --OXfL5xGRrasGEqWY > > > Content-Type: text/plain; charset=3Dus-ascii > > > Content-Disposition: inline > > > Content-Transfer-Encoding: quoted-printable > > > > > > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote: > > > > Author: cy > > > > Date: Wed Feb 20 06:14:57 2019 > > > > New Revision: 493407 > > > > URL: https://svnweb.freebsd.org/changeset/ports/493407 > > > >=3D20 > > > > Log: > > > > Remove whitespace in USE_QT, otherwise qmake_build is ignored. > > > > =3D20 > > > > Reported by: Paul Beard > > > >=3D20 > > > > Modified: > > > > head/graphics/xpdf4/Makefile > > > >=3D20 > > > > Modified: head/graphics/xpdf4/Makefile > > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= > D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D > > > > --- head/graphics/xpdf4/Makefile Wed Feb 20 04:50:53 2019 > (r49340 > > > 6) > > > > +++ head/graphics/xpdf4/Makefile Wed Feb 20 06:14:57 2019 > (r49340 > > > 7) > > > > @@ -27,8 +27,7 @@ SUB_FILES=3D3D xpdf-man.conf > > > > =3D20 > > > > USES=3D3D compiler:c++11-lang cmake localbase:ldflags \ > > > > desktop-file-utils qt:5 > > > > -USE_QT=3D3D buildtools_build,concurrent,core,gui,network,pr > intsuppo > > > rt,\ > > > > - qmake_build,svg,widgets > > > > +USE_QT=3D3D buildtools_build,concurrent,core,gui,network,pr > intsuppo > > > rt,qma=3D > > > ke_build,svg,widgets > > > > > > Next step: Replace the , with spaces to actually add Qt dependencies > > > to the port. Check with build-depends-list, run-depends-list, > > > stage-qa. Currently the port has no Qt 5 dependencies and it fails > > > to build in Poudriere: > > > > > > =3D3D=3D3D=3D3D> Checking for items in pkg-plist which are not in STAGE= > DIR > > > Error: Missing: libexec/xpdf/xpdf > > > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz > > > =3D3D=3D3D=3D3D> Error: Plist issues found. > >=20 > > This must have been wrong all along. I'm not sure how it would have=20 > > ever built before. > > Thanks for fixing it. I can confirm that it builds fine now for > me in Poudriere. It builds fine by hand here however, I killed the FreeBSD 11 build on one of my machines downstairs to reboot back to -current to start a poudriere build. (My sandbox machines double as poudriere build servers). It fails to build on my poudriere. It's missing another dependency. > > But let me clarify. It was not broken before, only after today. > Previously the port used an options helper like > > GUI_USE=3D QT=3Dx,y,z > > which was correct. This translates (see [1]) to > > =2Eif ${PORT_OPTIONS:MGUI} > USE_QT+=3D x y z > =2Eendif > > as it should be. It however does *not* translate to > > =2Eif ${PORT_OPTIONS:MGUI} > USE_QT+=3D x,y,z > =2Eendif > > So the refactoring from earlier (removing the GUI option) was not > correct and the problem was only introduced today. > > [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/make= > file-options.html#options-use Gotcha. Thanks. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.