From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Sep 10 14:26:38 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0DC0EFA0
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 10 Sep 2014 14:26:38 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CF8AB1A7C
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 10 Sep 2014 14:26:37 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8AEQboa029403
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 10 Sep 2014 14:26:37 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 181301] [NEW PORT] net/kamailio: Very fast and configurable
 open source SIP proxy
Date: Wed, 10 Sep 2014 14:26:37 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-qa, patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: olivermahmoudi@gmail.com
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-181301-13-UUZl4MXJCP@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-181301-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-181301-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Sep 2014 14:26:38 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=181301

--- Comment #18 from olivermahmoudi@gmail.com ---
(In reply to John Marino from comment #14)
> (In reply to olivermahmoudi from comment #13)
> > ### Version 1 
> > .if ${PORT_OPTIONS:MMYSQL}
> > BUILD_DEPENDS+=
> > ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server
> > RUN_DEPENDS+:=  ${BUILD_DEPENDS}
> > EXTRA_MODULES+= db_mysql
> > PLIST_SUB+=     MYSQL=""
> > .else
> > PLIST_SUB+=     MYSQL="@comment "
> > .endif
> > 
> > ### Version 2
> > OPTIONS_SUB=yes
> > .if ${PORT_OPTIONS:MMYSQL}
> > BUILD_DEPENDS+=
> > ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server
> > RUN_DEPENDS+:=  ${BUILD_DEPENDS}
> > EXTRA_MODULES+= db_mysql
> > .endif
> > 
> > whereas:
> > Version 1 == Version 2
> > 
> > then I can see what you mean and could update things to Version 2 via
> > OPTIONS_SUB. What I would essentially be carving out is this bit:
> > 
> > PLIST_SUB+=     MYSQL=""
> > .else
> > PLIST_SUB+=     MYSQL="@comment "
> > 
> > and it would still work.
> > 
> > Is this the point you were trying to make?
> 
> yes, but you can go even further.  e.g. 
> 
> 
> ### Version 3
> OPTIONS_SUB=yes
> MYSQL_BUILD_DEPENDS=
> ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server
> MYSQL_RUN_DEPENDS=
> ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server
> .include <bsd.options.mk>
> .if ${PORT_OPTIONS:MMYSQL}
> EXTRA_MODULES+= db_mysql
> .endif
> 
> 
> 
> See?
> 
> (btw, the mailing list has no authority here)

Yeah, the penny has dropped. Where I got a little confused here, was the part
where I have several conditions to take care of inside the if statements at the
same time. A prove of the concept as outlined in the Porter's Handbook would be
to break one big if statement down into several smaller ones and then the
OPTIONS_SUB approach is truly equivalent.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.