From owner-p4-projects@FreeBSD.ORG  Tue Oct 17 08:16:23 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6566216A417; Tue, 17 Oct 2006 08:16:23 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2461C16A415
	for <perforce@FreeBSD.org>; Tue, 17 Oct 2006 08:16:23 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4E96B43D83
	for <perforce@FreeBSD.org>; Tue, 17 Oct 2006 08:16:20 +0000 (GMT)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9H8GKlG023392
	for <perforce@FreeBSD.org>; Tue, 17 Oct 2006 08:16:20 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9H8GJfe023389
	for perforce@freebsd.org; Tue, 17 Oct 2006 08:16:19 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Tue, 17 Oct 2006 08:16:19 GMT
Message-Id: <200610170816.k9H8GJfe023389@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 108021 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2006 08:16:23 -0000

http://perforce.freebsd.org/chv.cgi?CH=108021

Change 108021 by rdivacky@rdivacky_witten on 2006/10/17 08:15:38

	Remove locking of the proc. Holding of proctree_lock is sufficient.
	
	Pointed out by: jhb

Affected files ...

.. //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#12 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#12 (text+ko) ====

@@ -212,12 +212,8 @@
 	q = LIST_FIRST(&p->p_children);
 	for (; q != NULL; q = nq) {
 	   	nq = LIST_NEXT(q, p_sibling);
-	   	PROC_LOCK(q);
-	   	if (q->p_flag & P_WEXIT) {
-		   	PROC_UNLOCK(q);
+	   	if (q->p_flag & P_WEXIT)
 		   	continue;
-		}
-	   	PROC_UNLOCK(q);
 		if (__predict_false(q->p_sysent != &elf_linux_sysvec))
    		   	continue;
    	   	em = em_find(q, EMUL_UNLOCKED);