Date: Tue, 09 Jun 2026 12:53:13 +0000 From: Max Brazhnikov <makc@FreeBSD.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org Subject: git: 87873bd05c9a - 2026Q2 - sysutils/plasma6-ksystemstats: Fix memory leak Message-ID: <6a280cb9.3e4ed.30022685@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch 2026Q2 has been updated by makc: URL: https://cgit.FreeBSD.org/ports/commit/?id=87873bd05c9a32128c00dcbee87a8fff012f4746 commit 87873bd05c9a32128c00dcbee87a8fff012f4746 Author: Max Brazhnikov <makc@FreeBSD.org> AuthorDate: 2026-06-09 12:06:01 +0000 Commit: Max Brazhnikov <makc@FreeBSD.org> CommitDate: 2026-06-09 12:52:38 +0000 sysutils/plasma6-ksystemstats: Fix memory leak PR: 295310 Submitted by: avg (cherry picked from commit b6754dfb149895f492fa43de28e1608d79f1675f) --- sysutils/plasma6-ksystemstats/Makefile | 1 + sysutils/plasma6-ksystemstats/files/patch-network | 28 +++++++++++------------ 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/sysutils/plasma6-ksystemstats/Makefile b/sysutils/plasma6-ksystemstats/Makefile index 46fc36be79c1..f55aab85afdb 100644 --- a/sysutils/plasma6-ksystemstats/Makefile +++ b/sysutils/plasma6-ksystemstats/Makefile @@ -1,5 +1,6 @@ PORTNAME= ksystemstats DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= sysutils kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/sysutils/plasma6-ksystemstats/files/patch-network b/sysutils/plasma6-ksystemstats/files/patch-network index 5f5793e78663..1d86bc0737db 100644 --- a/sysutils/plasma6-ksystemstats/files/patch-network +++ b/sysutils/plasma6-ksystemstats/files/patch-network @@ -37,7 +37,7 @@ auto backend = func(this); --- /dev/null +++ plugins/network/SysctlBackend.cpp -@@ -0,0 +1,160 @@ +@@ -0,0 +1,158 @@ +/* + * SPDX-FileCopyrightText: 2022 Jesper Schmitz Mouridsen <jesper@schmitz.computer> + * @@ -110,33 +110,31 @@ + char addr_buf[NI_MAXHOST]; + QStringList ipv4_addrs; + QStringList ipv6_addrs; ++ ifaddrs *ifap0 = nullptr; ++ ifaddrs *ifap; + struct sockaddr_in *sin; + -+ ipv4_addrs.clear(); -+ ipv6_addrs.clear(); -+ ifaddrs *ifap; -+ bzero(&ifap, sizeof(ifap)); -+ for (getifaddrs(&ifap); ifap != nullptr; ifap = ifap->ifa_next) { ++ getifaddrs(&ifap0); ++ for (ifap = ifap0; ifap != nullptr; ifap = ifap->ifa_next) { + if (name() == QString::fromLatin1(ifap->ifa_name)) { + sin = reinterpret_cast<struct sockaddr_in *>(ifap->ifa_addr); -+ if (sin == NULL) ++ if (sin == nullptr) + return; + -+ if(getnameinfo(ifap->ifa_addr, sin->sin_len, addr_buf, sizeof(addr_buf), NULL, 0, NI_NUMERICHOST)==0) { -+ -+ if (sin->sin_family == AF_INET) { ++ if (getnameinfo(ifap->ifa_addr, sin->sin_len, addr_buf, sizeof(addr_buf), ++ NULL, 0, NI_NUMERICHOST) == 0) { ++ if (sin->sin_family == AF_INET) { + ipv4_addrs << QString::fromLatin1(addr_buf); -+ } ++ } + if (sin->sin_family == AF_INET6) { -+ ipv6_addrs << QString::fromLatin1(addr_buf); ++ ipv6_addrs << QString::fromLatin1(addr_buf); + } -+ } -+ ++ } + } + } + m_ipv4Sensor->setValue(ipv4_addrs.join("\n")); + m_ipv6Sensor->setValue(ipv6_addrs.join("\n")); -+ freeifaddrs(ifap); ++ freeifaddrs(ifap0); +} + +SysctlNetDevice::~SysctlNetDevice()home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a280cb9.3e4ed.30022685>