From owner-dev-commits-src-main@freebsd.org  Mon Aug  2 20:48:10 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20A2967A637;
 Mon,  2 Aug 2021 20:48:10 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GdqpK5zDWz3Kcs;
 Mon,  2 Aug 2021 20:48:09 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 172Km1DW009441
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 2 Aug 2021 23:48:04 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 172Km1DW009441
Received: (from kostik@localhost)
 by tom.home (8.16.1/8.16.1/Submit) id 172Km1gR009440;
 Mon, 2 Aug 2021 23:48:01 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Mon, 2 Aug 2021 23:48:01 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Alexander Motin <mav@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
 dev-commits-src-main@freebsd.org
Subject: Re: git: 74f80bc1af2f - main - coretemp(4): Switch to
 smp_rendezvous_cpus().
Message-ID: <YQhaAQGs2giP/ISy@kib.kiev.ua>
References: <202107300326.16U3QGHR070204@gitrepo.freebsd.org>
 <YQVGn7VhKstcGndr@kib.kiev.ua>
 <5b8b9ee4-4c90-ed32-de37-9d03fd812550@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b8b9ee4-4c90-ed32-de37-9d03fd812550@FreeBSD.org>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home
X-Rspamd-Queue-Id: 4GdqpK5zDWz3Kcs
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 20:48:10 -0000

On Mon, Aug 02, 2021 at 12:15:55PM -0400, Alexander Motin wrote:
> On 31.07.2021 08:48, Konstantin Belousov wrote:
> >> +static void
> >> +coretemp_wrmsr(void *arg)
> >> +{
> >> +	struct coretemp_args *args = arg;
> >> +
> >> +	wrmsr(args->msr, args->val);
> >> +}
> > We have x86_msr_op().  It covers coretemp_wrmsr(), and with slight
> > change of the interface would also handle the functionality of
> > coretemp_rdmsr().
> 
> As I see x86_msr_op() is tuned for MSR modification on all CPUs, while
> this code touches one CPU at a time.

https://reviews.freebsd.org/D31386