From owner-freebsd-testing@FreeBSD.ORG  Mon Mar  3 18:31:36 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8F5EBC6B;
 Mon,  3 Mar 2014 18:31:36 +0000 (UTC)
Received: from mail-vc0-x22a.google.com (mail-vc0-x22a.google.com
 [IPv6:2607:f8b0:400c:c03::22a])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 26D4EAF7;
 Mon,  3 Mar 2014 18:31:36 +0000 (UTC)
Received: by mail-vc0-f170.google.com with SMTP id hu8so4008097vcb.29
 for <multiple recipients>; Mon, 03 Mar 2014 10:31:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=k9uRFjPMUPIM0wlV7pvnOD6uOEPnGafbZ+YjTV9pjAA=;
 b=kz9D0o6WEZdNV/9I9HWJYYvocVLLTdBk4Jv/y+fSOItvTx0jGdXaAk1FqGj7Hwo6D4
 5lNQztgDejf9nmygwxKv7J33lhPUD1YpfPtB0VFJqEZsUyp/TuouVQdT10ydgSn3MffB
 3hCrXKFM1VULFC2SZE5YEiXSC9zAFCVESxHw8EWvTOUMybVaeky9tPip5W05EtJsLnn+
 55Vq1vJzELYDR9zVYRrwPfN58bhf7Lhpj/GyHaHgy01AL0FO7wZvckqp2cjgffrTrZ2n
 9Lr5BzHzrVTUsu7b5gu6MBXDU5C9Hn+n0S69acbGjHIhK460Yb3BeSOU06bq747L7ZK7
 2Gcg==
MIME-Version: 1.0
X-Received: by 10.58.128.72 with SMTP id nm8mr18749187veb.18.1393871495358;
 Mon, 03 Mar 2014 10:31:35 -0800 (PST)
Received: by 10.221.67.136 with HTTP; Mon, 3 Mar 2014 10:31:35 -0800 (PST)
In-Reply-To: <CAFY7cWBHaftY=LOen=_gescMkoyCoKU69HRyqOfW10YAZ2OzuQ@mail.gmail.com>
References: <6079AD8F-5EBB-431C-A06B-9B51E2729F5A@gmail.com>
 <B90AA730-B7B8-4F1A-9D07-67861C9A6401@meroh.net>
 <FA467521-BB53-47C0-BAE1-8BCAE29F922F@gmail.com>
 <CADyfeQXG6KGwgT1X90Ymr+FYnwL74H_G2zBvkgdzEhPospNM8A@mail.gmail.com>
 <4A25ADF9-3714-4006-ACB6-F8C745CB38AE@gmail.com>
 <CAFY7cWBHaftY=LOen=_gescMkoyCoKU69HRyqOfW10YAZ2OzuQ@mail.gmail.com>
Date: Mon, 3 Mar 2014 10:31:35 -0800
Message-ID: <CAGHfRMCASnNx2t9MiAQ5cSWR0R7wuswMnZ0J1Hpo7WjoUdvbrA@mail.gmail.com>
Subject: Re: [PATCH v2] convert bin/date over to ATF
From: Garrett Cooper <yaneurabeya@gmail.com>
To: Julio Merino <jmmv@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
 Giorgos Keramidas <keramida@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Mar 2014 18:31:36 -0000

On Sun, Mar 2, 2014 at 1:22 PM, Julio Merino <jmmv@freebsd.org> wrote:
> On Mon, Jan 27, 2014 at 5:03 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>         The attached patch incorporates the input from Julio for converting bin/date/tests over to ATF.
>
> Apologies for the delay here as well...
>
> Pretty much all style nits:
>
> * This file is full of boilerplate and it's really hard to actually
> see the tests. I think this would benefit from a simple helper
> function that calls atf_test_case and evals the tiny body() with the
> call to check.

Ok.

> * I'd get rid of the descr definitions; they provide no value.

Ok.

> * I'd also get rid of all the horizontal dividing lines.  If you make
> the test case definitions compact, they just serve to increase the
> file length.

Ok.

> * Remove the TZ and LC_ALL overrides.  This is a given within ATF.

Ok.

> * Why "format_string_functional_test"?  I'd just call it "format_string_test".

I guess I could...

> * I don't think the # vim trailing line belongs in the tree.

Ok.

-Garrett