From owner-freebsd-commit Wed Nov 15 05:55:25 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA28837 for freebsd-commit-outgoing; Wed, 15 Nov 1995 05:55:25 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA28823 for cvs-all-outgoing; Wed, 15 Nov 1995 05:55:21 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA28809 for cvs-usrsbin-outgoing; Wed, 15 Nov 1995 05:55:17 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id FAA28800 ; Wed, 15 Nov 1995 05:55:10 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id FAA28670; Wed, 15 Nov 1995 05:55:08 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id FAA00756; Wed, 15 Nov 1995 05:54:22 -0800 Message-Id: <199511151354.FAA00756@corbin.Root.COM> To: Bruce Evans cc: CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "Thu, 16 Nov 95 00:41:41 +1100." <199511151341.AAA05911@godzilla.zeta.org.au> From: David Greenman Reply-To: davidg@Root.COM Date: Wed, 15 Nov 1995 05:54:22 -0800 Sender: owner-commit@FreeBSD.ORG Precedence: bulk >> Modified: usr.sbin/syslogd syslogd.c >> Log: >> With the recent 'make install' change in the kernel build makefiles, an >> `interesting' feature of syslogd turned up. It calls getbootfile() for each >> log entry. Since the kernel makefile now changes kern.bootfile when doing >> a 'make install', it's quite startling to see the syslog lines change. > >I think that was a feature. The kernel name really did change. It's >interesting that getbootfile() doesn't cache the old name although >that would be easy using the static buffer. There are now two static >buffers, one of length MAXPATHLEN in getbootfile() and one of length >MAXLINE+1 in syslogd.c. MAXLINE just happens to be the same as >MAXPATHLEN. The sysctl crap in the Makefile is bogus and should be removed. My kernel is often not called "/kernel" and pretending that it was is wrong. The bootfile name should be read-only and the Makefile should not be messing with it. -DG