From owner-freebsd-current Mon Aug 31 07:27:27 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA28025 for freebsd-current-outgoing; Mon, 31 Aug 1998 07:27:27 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from tim.xenologics.com (tim.xenologics.com [194.77.5.24]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA28003 for ; Mon, 31 Aug 1998 07:27:23 -0700 (PDT) (envelope-from seggers@semyam.dinoco.de) Received: (from uucp@localhost) by tim.xenologics.com (8.8.5/8.8.8) with UUCP id QAA09801; Mon, 31 Aug 1998 16:06:58 +0200 (MET DST) Received: from semyam.dinoco.de (semyam.dinoco.de [127.0.0.1]) by semyam.dinoco.de (8.9.1/8.8.8) with ESMTP id IAA01965; Mon, 31 Aug 1998 08:22:40 +0200 (CEST) (envelope-from seggers@semyam.dinoco.de) Message-Id: <199808310622.IAA01965@semyam.dinoco.de> To: Kris Kennaway Cc: freebsd-current@FreeBSD.ORG, seggers@semyam.dinoco.de Subject: Re: IPFW showing extra lines In-reply-to: Your message of "Sun, 30 Aug 1998 22:55:28 +0200." <199808302055.WAA02656@semyam.dinoco.de> Date: Mon, 31 Aug 1998 08:22:40 +0200 From: Stefan Eggers Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >From my patch: > valsize = len; > if (sopt->sopt_valsize < valsize) { > valsize = sopt->sopt_valsize; > - sopt->sopt_valsize = len; > } > + sopt->sopt_valsize = len; And here the correct fix should have been "= valsize" instead of "= len" - otherwise the result length might end up being larger than the buffer provided. I think then the fix is OK. Stefan. -- Stefan Eggers Lu4 yao2 zhi1 ma3 li4, Max-Slevogt-Str. 1 ri4 jiu3 jian4 ren2 xin1. 51109 Koeln Federal Republic of Germany To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message