From owner-svn-ports-all@FreeBSD.ORG  Wed Oct 16 07:29:43 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id DB7F31BB;
 Wed, 16 Oct 2013 07:29:43 +0000 (UTC) (envelope-from bsam@passap.ru)
Received: from forward4h.mail.yandex.net (forward4h.mail.yandex.net
 [IPv6:2a02:6b8:0:f05::4])
 by mx1.freebsd.org (Postfix) with ESMTP id 8E4F526DE;
 Wed, 16 Oct 2013 07:29:43 +0000 (UTC)
Received: from smtp4h.mail.yandex.net (smtp4h.mail.yandex.net [84.201.186.21])
 by forward4h.mail.yandex.net (Yandex) with ESMTP id 6024B1B20EBE;
 Wed, 16 Oct 2013 11:29:40 +0400 (MSK)
Received: from smtp4h.mail.yandex.net (localhost [127.0.0.1])
 by smtp4h.mail.yandex.net (Yandex) with ESMTP id B45712C1BC2;
 Wed, 16 Oct 2013 11:29:39 +0400 (MSK)
Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58])
 by smtp4h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Twy6htJEJV-TcjqNLxj;
 Wed, 16 Oct 2013 11:29:39 +0400
Message-ID: <525E4062.70107@passap.ru>
Date: Wed, 16 Oct 2013 11:29:38 +0400
From: Boris Samorodov <bsam@passap.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Ganael LAPLANCHE <martymac@FreeBSD.org>, 
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r330484 - in head: . emulators emulators/dolphin-emu
 emulators/dolphin-emu-devel emulators/dolphin-emu/files
References: <201310160716.r9G7GvpJ036930@svn.freebsd.org>
In-Reply-To: <201310160716.r9G7GvpJ036930@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2013 07:29:43 -0000

16.10.2013 11:16, Ganael LAPLANCHE пишет:

> +.if !empty(ICONV_LIB)

Is there a specific reason to use a negate check here?

> +CMAKE_ARGS+=	-DUSE_ICONV:BOOL=ON
> +.else
> +CMAKE_ARGS+=	-DUSE_ICONV:BOOL=OFF
> +.endif

That means that the port does not use (need) iconv at 10.x and up
systems. Is it really the case? Can the port use native iconv at
10.x and up systems?

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve