From owner-freebsd-current@FreeBSD.ORG Sun Sep 4 22:39:10 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E27B516A41F; Sun, 4 Sep 2005 22:39:10 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1831D43D45; Sun, 4 Sep 2005 22:39:09 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from ury.york.ac.uk (ury.york.ac.uk [144.32.108.81]) by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id j84Md7k2015868; Sun, 4 Sep 2005 23:39:07 +0100 (BST) Received: from ury.york.ac.uk (localhost.york.ac.uk [127.0.0.1]) by ury.york.ac.uk (8.13.1/8.13.1) with ESMTP id j84MrX1F031146; Sun, 4 Sep 2005 23:53:33 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from localhost (gavin@localhost) by ury.york.ac.uk (8.13.1/8.13.1/Submit) with ESMTP id j84MrXwC031143; Sun, 4 Sep 2005 23:53:33 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) X-Authentication-Warning: ury.york.ac.uk: gavin owned process doing -bs Date: Sun, 4 Sep 2005 23:53:33 +0100 (BST) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: John Baldwin In-Reply-To: <200508311636.49278.jhb@FreeBSD.org> Message-ID: <20050904234626.H31032@ury.york.ac.uk> References: <200508311636.49278.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk Cc: current@freebsd.org Subject: Re: [PATCH] Locking fixes for tl(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2005 22:39:11 -0000 On Wed, 31 Aug 2005, John Baldwin wrote: > Patch fixes locking for tl(4) and marks it MPSAFE. Please test, thanks! > > http://www.FreeBSD.org/~jhb/patches/tl_locking.patch Doesn't work, I'm afraid. Panic on attach: tl0: port 0x2800-0x280f irq 5 at device 7.0 on pci1 Fatal trap 12: page fault while in kernel mode cpuid = 0; apic id = 00 fault virtual address = 0xcc fault code = supervisor read, page not present instruction pointer = 0x20:0xc074bc7e stack pointer = 0x28:0xc0c20a54 frame pointer = 0x28:0xc0c20a60 code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, def32 1, gran 1 processor eflags = interrupt enabled, resume, IOPL = 0 current process = 0 (swapper) [thread pid 0 tid 0 ] Stopped at tl_mii_writereg+0xe: cmpl $0,0xcc(%eax) db> tr Tracing pid 0 tid 0 td 0xc0925e20 tl_mii_writereg(c1619000,c0c20a7c,c0c20a7c,8,c1576800) at tl_mii_writereg+0xe tl_miibus_writereg(c1576800,0,0,4c00) at tl_miibus_writereg+0x39 tl_hardreset(c1576800,c1619000,1,c1576800,e11ab70) at tl_hardreset+0x32 tl_attach(c1576800) at tl_attach+0x2b6 device_attach(c1576800,e,c1576800,c1576700,c1576700) at device_attach+0x58 device_probe_and_attach(c1576800) at device_probe_and_attach+0xe0 bus_generic_attach(c1576700,c1576700,1,7c,1) at bus_generic_attach+0x16 pci_attach(c1576700) at pci_attach+0x7f ... Note that I have not tried this machine on 7-CURRENT but without your tl locking patch, so it's possible that it's some other change in HEAD that cause this panic. It runs happily with 6.0-BETA3. Gavin