From owner-freebsd-current@FreeBSD.ORG Sat Apr 26 23:56:26 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A24237B401 for ; Sat, 26 Apr 2003 23:56:26 -0700 (PDT) Received: from ms-smtp-03.southeast.rr.com (ms-smtp-03.southeast.rr.com [24.93.67.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FF3943FA3 for ; Sat, 26 Apr 2003 23:56:25 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from mail5.nc.rr.com (fe5 [24.93.67.52])h3R6qfNG011138 for ; Sun, 27 Apr 2003 02:55:00 -0400 (EDT) Received: from creme-brulee.marcuscom.com ([66.57.17.158]) by mail5.nc.rr.com with Microsoft SMTPSVC(5.5.1877.757.75); Sun, 27 Apr 2003 01:51:42 -0400 Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) h3R5q5aa059600 for ; Sun, 27 Apr 2003 01:52:05 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: current@freebsd.org Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EbhChI0NRJb8Gs1namoU" Organization: MarcusCom, Inc. Message-Id: <1051422865.61654.2.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.3.2 (Preview Release) Date: 27 Apr 2003 01:54:26 -0400 X-Spam-Status: No, hits=-12.7 required=5.0 tests=BAYES_00,PGP_SIGNATURE_2 autolearn=ham version=2.50 X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Subject: Segfault in killall X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2003 06:56:26 -0000 --=-EbhChI0NRJb8Gs1namoU Content-Type: multipart/mixed; boundary="=-h1i109EZrSNgokcR7Moh" --=-h1i109EZrSNgokcR7Moh Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I was playing around with jails on -CURRENT, and I noticed typing "killall -j" causes a segfault in strtol. I didn't see a PR opened, but I can open one if need be. The attached fix is pretty simple. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-h1i109EZrSNgokcR7Moh Content-Disposition: attachment; filename=killall.c.diff Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; name=killall.c.diff; charset=ISO-8859-1 --- src/usr.bin/killall.c.orig Sun Apr 27 01:52:18 2003 +++ src/usr.bin/killall.c Sun Apr 27 01:55:12 2003 @@ -153,6 +153,8 @@ ++av; --ac; jflag++; + if (!*av) + errx(1, "must specify jid"); jid =3D strtol(*av, &ep, 10); if (!*av || *ep) errx(1, "illegal jid: %s", *av); --=-h1i109EZrSNgokcR7Moh-- --=-EbhChI0NRJb8Gs1namoU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+q3CRb2iPiv4Uz4cRAi7HAJ4psNjad6vB7+mCd8QLgfl/RFQQtACffOrT 8E90KED/RMomxuCPBLjP18E= =amIw -----END PGP SIGNATURE----- --=-EbhChI0NRJb8Gs1namoU--