From owner-svn-src-head@freebsd.org Wed Nov 29 13:46:46 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC319E5498F; Wed, 29 Nov 2017 13:46:46 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5F37C74FF4; Wed, 29 Nov 2017 13:46:45 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 3yn1zR1JzqzbT4; Wed, 29 Nov 2017 14:46:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=mail; t=1511963200; x=1513777601; bh=4q7G999BMI0pdr dcrnFa80VRk5ilcIPrcv3oAQ3/Yj8=; b=YXB9cb0MEMptzSqJynBN8zbJZvRNF0 3wcw1uT+lc5Z934g+/e3l5tQcedWSd7e2LNS6btU1tJ7/MHH4vZdmtlt7ofYQ+jV Wa9onX/0UuLJGDhY5YQTiivK/YSTXVmnyZ+iOdtgsliXUCuNgzC/bToNpLW8J+jG czx3E4XXD/140= Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024) with ESMTP id A2EHWK0kPn5O; Wed, 29 Nov 2017 14:46:40 +0100 (CET) Received: from tommy.madpilot.net (micro.madpilot.net [88.149.173.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.madpilot.net (Postfix) with ESMTPSA; Wed, 29 Nov 2017 14:46:40 +0100 (CET) Subject: Re: svn commit: r326364 - head/sys/kern To: "Hartmann, O." , Alexey Dokuchaev Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org References: <201711291249.vATCnMaF075503@repo.freebsd.org> <20171129141343.1d6331f8@hermann> From: Guido Falsi Message-ID: <70c6fc56-0c43-c185-2363-95e312b10c93@madpilot.net> Date: Wed, 29 Nov 2017 14:46:40 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171129141343.1d6331f8@hermann> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 13:46:46 -0000 On 11/29/2017 14:14, Hartmann, O. wrote: > On Wed, 29 Nov 2017 12:49:22 +0000 (UTC) > Alexey Dokuchaev wrote: > >> Author: danfe (ports committer) >> Date: Wed Nov 29 12:49:22 2017 >> New Revision: 326364 >> URL: https://svnweb.freebsd.org/changeset/base/326364 >> >> Log: >> Fix several noticed style issues. >> >> Reviewed by: bde >> Approved by: bapt >> >> Modified: >> head/sys/kern/subr_kdb.c >> >> Modified: head/sys/kern/subr_kdb.c >> ============================================================================== >> --- head/sys/kern/subr_kdb.c Wed Nov 29 10:04:11 2017 >> (r326363) +++ head/sys/kern/subr_kdb.c Wed Nov 29 12:49:22 >> 2017 (r326364) @@ -250,7 +250,6 @@ kdb_reboot(void) >> * its arguments. Its up to the caller to ensure that the state >> variable is >> * consistent. >> */ >> - >> #define KEY_CR 13 /* CR '\r' */ >> #define KEY_TILDE 126 /* ~ */ >> #define KEY_CRTLB 2 /* ^B */ >> @@ -362,7 +361,6 @@ kdb_alt_break_gdb(int key, int *state) >> * is selected or the current debugger does not support backtraces, >> this >> * function silently returns. >> */ >> - >> void >> kdb_backtrace(void) >> { >> @@ -410,7 +408,6 @@ kdb_backtrace_thread(struct thread *td) >> /* >> * Set/change the current backend. >> */ >> - >> int >> kdb_dbbe_select(const char *name) >> { >> @@ -450,7 +447,6 @@ kdb_enter(const char *why, const char *msg) >> /* >> * Initialize the kernel debugger interface. >> */ >> - >> void >> kdb_init(void) >> { >> @@ -485,7 +481,6 @@ kdb_init(void) >> /* >> * Handle contexts. >> */ >> - >> void * >> kdb_jmpbuf(jmp_buf new) >> { >> @@ -521,9 +516,8 @@ kdb_reenter_silent(void) >> } >> >> /* >> - * Thread related support functions. >> + * Thread-related support functions. >> */ >> - >> struct pcb * >> kdb_thr_ctx(struct thread *thr) >> { >> @@ -617,7 +611,6 @@ kdb_thr_select(struct thread *thr) >> /* >> * Enter the debugger due to a trap. >> */ >> - >> int >> kdb_trap(int type, int code, struct trapframe *tf) >> { >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to >> "svn-src-head-unsubscribe@freebsd.org" > > r326363 produces a panic while performing installworld. This happens > even with the recommended procedure in singleuser mode with booted > kerenl r326363. While installing manpages, the system went down > reporting a "spinlock held too long". > I'm having a similar problem, looks like it's related to r326200. I've locally reverted that(and it's followup r326237) and testing again. -- Guido Falsi