Date: Sat, 24 Jul 2010 14:54:36 -0400 From: George Neville-Neil <gnn@freebsd.org> To: pluknet <pluknet@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210428 - head/sys/dev/e1000 Message-ID: <2A761020-866F-48C2-B8B9-8C847C668A25@freebsd.org> In-Reply-To: <AANLkTikYRjLeC7z5fb34=DsAi2PvBZT5uM4xffVgL9Br@mail.gmail.com> References: <201007231753.o6NHresT072278@svn.freebsd.org> <AANLkTikYRjLeC7z5fb34=DsAi2PvBZT5uM4xffVgL9Br@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 23, 2010, at 15:27 , pluknet wrote: > On 23 July 2010 21:53, George V. Neville-Neil <gnn@freebsd.org> wrote: >> Author: gnn >> Date: Fri Jul 23 17:53:39 2010 >> New Revision: 210428 >> URL: http://svn.freebsd.org/changeset/base/210428 >>=20 >> Log: >> Fix a bug in the statistics code for tracking the head and >> tail pointers of the tx and rx queues. We needed a SYSCTL_PROC >> to correctly get the values at run time. >>=20 >> Submitted by: Andrew Boyer aboyer at averesystems.com >> MFC after: 1 week >>=20 >> Modified: >> head/sys/dev/e1000/if_igb.c >>=20 >> Modified: head/sys/dev/e1000/if_igb.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/e1000/if_igb.c Fri Jul 23 17:44:01 2010 = (r210427) >> +++ head/sys/dev/e1000/if_igb.c Fri Jul 23 17:53:39 2010 = (r210428) >> @@ -4927,6 +4927,74 @@ igb_update_vf_stats_counters(struct adap >> } >>=20 >>=20 >> +/** igb_sysctl_tdh_handler - Handler function >> + * Retrieves the TDH value from the hardware >> + */ >> +static int igb_sysctl_tdh_handler(SYSCTL_HANDLER_ARGS) >> +{ >=20 > ^^ > This function definition (and three ones below) breaks style(9): > " The function type should be on a line by itself preceding the = function." >=20 Quite right, I've committed a style(9) fix. Thanks, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2A761020-866F-48C2-B8B9-8C847C668A25>