From nobody Sat Jun 28 01:23:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTZS02bGYz60Wy1; Sat, 28 Jun 2025 01:23:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTZS01p9Kz3s1F; Sat, 28 Jun 2025 01:23:12 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751073792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jQKVorYAHdjDBwJY51nOe4f+8mXuSPxKFSHTCXW+qIM=; b=uplBfMATteS5KOMuLhpkqch+HREJ3IbbY1FKrLLcUKND+LMWN89xLwEBdFpRe5jiuUPQHM szlbF/ED88rEM1ZbdntyTHYw6xoWZQY12yk3icTjqTb5daVXFNrNOVgAqM3RRbFPSwQup8 YayX0WbvTiA1hSIz8G6twQthSGkHdp3M6kXgMmwVl1hGa/Ce3uzxf0R1ffU0CBK58WBz0a 2+7Fzl5OFTkiCbCZzXKgYuYuoKsIKaMZzOmab9rq4iMefIdEwwpNe1jnYfPRlc5Oe2vZjY NRhXgHO21XdIll12bbe1pYwkoQsrhG6ozo9Kohb+RTn5ybIjENaWteY3lznU4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751073792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jQKVorYAHdjDBwJY51nOe4f+8mXuSPxKFSHTCXW+qIM=; b=JMPBHKwoomBwl0K7dvDEW32kHWE2129tHO539+qsesHF6J0XoNFQoIwZ+lqFdjtEEGjp4B MoeJiMHe91Ol9S6XwfIiXOxtetvYL+ZESn24RMVC+A4Uh3SzCB/nPzUt2tbNYhC9CG2rhm FsJHxt+hPako/RZYwUfWBsNyze0kN9EaUR0xzgIOgqvBFrEbb0WVSkF3yVW/gxOy0zVOMe V+Fw/252WknprgZ1iinHvMhqVMvoiR6lK3C9l4cMvf6ivK3tesUooDcr2bP+VxiSrojDUC lU1IoJj5+bEse7+/3ytFUPcKfumysAmpOCi8VMW7l8ZtJzTUx//5V59m6O6k/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751073792; a=rsa-sha256; cv=none; b=GiV09l3Og2D56LoIDXNFH4nRHzPtTfmny0PFfKVrdfPKiHloIoSEffmZGCTnVCggdbAGmw L+oBqH6oyoNu7Nfk7jqrJ7BhjMVHqPJo8JZOOSkY6bfmZErVzOXii3T84Jw1NIXNGMggjW ErA1Xr5zE0d+Uf4iwgzbfD//gJAceskWxkyP9kwJ9KHSTGgua+tHlQiGX4WANM3o1fns1x 6cO/dl2zt3pXULygVVQGItL0HZ2jtDY1YxS555+wBnhaS4unj+YIWV5vbKk9tN0ATO4VPM EBxVjD6PLSP7pKk9V6KlG4NELwgl6VsFx1ti3tVHmKANiX8aUvGOfTmvIarYOQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bTZRz36jzzLT5; Sat, 28 Jun 2025 01:23:11 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 27 Jun 2025 18:23:08 -0700 From: Gleb Smirnoff To: Alan Somers , Damin Rido Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0726c6574f88 - main - sockstat: Add automatic column sizing and remove -w option Message-ID: References: <202506271559.55RFxWdm024724@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506271559.55RFxWdm024724@gitrepo.freebsd.org> Hi, On Fri, Jun 27, 2025 at 03:59:32PM +0000, Alan Somers wrote: A> commit 0726c6574f889507e5030173bf4c82c80911394d A> Author: Damin Rido A> AuthorDate: 2025-06-12 09:12:49 +0000 A> Commit: Alan Somers A> CommitDate: 2025-06-27 15:54:41 +0000 A> A> sockstat: Add automatic column sizing and remove -w option A> A> Refactor sockstat to dynamically size table columns based on content. A> This eliminates the need for the -w option, which is now ignored A> for backwards compatibility. A> A> Numeric columns are now right-aligned for improved readability; A> previously, they were left-aligned. A> A> Unknown fields are now consistently shown as "??" instead of a mix A> of "", "?", and "?" for output uniformity. A> A> Sponsored by: Google, LLC (GSoC 2025) A> MFC after: 2 weeks A> Reviewed by: asomers A> Pull Request: https://github.com/freebsd/freebsd-src/pull/1720 A> --- A> usr.bin/sockstat/sockstat.1 | 6 +- A> usr.bin/sockstat/sockstat.c | 622 +++++++++++++++++++++++++++----------------- A> 2 files changed, 392 insertions(+), 236 deletions(-) The commit message looks promising, but so far the output of the program that I use daily has been made much worsr :( First, there is a spurious second newline on every line. Even after the header line! How could that pass through minimal testing? Second, the default output now just inserts a huge whitespace "column" in the middle of the list, making it extermely wide. Note, that before this change the default output was fitting into 80 char terminal. Now it is not fitting and without any good reason to do so. I really would prefer this reverted and re-tested by a wider audience before pushing it back in. -- Gleb Smirnoff