Date: Wed, 22 Aug 2001 00:41:49 -0700 From: Terry Lambert <tlambert2@mindspring.com> To: Matt Dillon <dillon@earth.backplane.com> Cc: Jake Burkholder <jake@k7.locore.ca>, John Baldwin <jhb@FreeBSD.ORG>, freebsd-smp@FreeBSD.ORG, freebsd-alpha@FreeBSD.ORG Subject: Re: Preliminary proposed rollup of kernel submap initialization code Message-ID: <3B83623D.9DC45B93@mindspring.com> References: <200108210157.f7L1vAh10384@k7.locore.ca> <200108211736.f7LHaoC64628@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matt Dillon wrote:
> -static vm_offset_t buffer_sva, buffer_eva;
> -vm_offset_t clean_sva, clean_eva;
> -static vm_offset_t pager_sva, pager_eva;
> +struct kva_md_info kmi;
You make this a non-static global...
> + vm_ksubmap_init(&kmi);
Then you pass it's address in...
> +void
> +vm_ksubmap_init(struct kva_md_info *kmi)
> +{
And then use much more expensive pointer arithmatic...
> + buffer_map = kmem_suballoc(clean_map, &kmi->buffer_sva,
> + &kmi->buffer_eva, (nbuf*BKVASIZE));
I understand that this is called once, but doesn't this
really obfuscate things?
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B83623D.9DC45B93>