From owner-dev-commits-src-main@freebsd.org  Sun Jan 24 19:46:57 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id E15554D815C;
 Sun, 24 Jan 2021 19:46:57 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
Received: from annwfn.iks-jena.de (annwfn.iks-jena.de [IPv6:2001:4bd8::19])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DP3RP4ZnJz4VZD;
 Sun, 24 Jan 2021 19:46:57 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
X-SMTP-Sender: IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f
Received: from belenus.iks-jena.de (belenus.iks-jena.de
 [IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f])
 by annwfn.iks-jena.de (8.15.2/8.15.2) with ESMTPS id 10OJke5f027025
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
 Sun, 24 Jan 2021 20:46:40 +0100
X-MSA-Host: belenus.iks-jena.de
Received: (from lutz@localhost)
 by belenus.iks-jena.de (8.14.3/8.14.1/Submit) id 10OJkeEv006623;
 Sun, 24 Jan 2021 20:46:40 +0100
Date: Sun, 24 Jan 2021 20:46:40 +0100
From: Lutz Donnerhacke <lutz@donnerhacke.de>
To: Lutz Donnerhacke <donner@FreeBSD.org>
Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
 dev-commits-src-main@FreeBSD.org
Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC
 6598/Carrier Grade NAT support
Message-ID: <20210124194640.GA6527@belenus.iks-jena.de>
References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202101241941.10OJfCGA013081@gitrepo.freebsd.org>
X-message-flag: Please send plain text messages only. Thank you.
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Queue-Id: 4DP3RP4ZnJz4VZD
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jan 2021 19:46:57 -0000

On Sun, Jan 24, 2021 at 07:41:12PM +0000, Lutz Donnerhacke wrote:
> commit 5fe433a6e4d8cab6b64284698301afc0c55a9db2
> Author:     Neel Chauhan <nc@FreeBSD.org>
> AuthorDate: 2021-01-24 19:23:39 +0000
> Commit:     Lutz Donnerhacke <donner@FreeBSD.org>
> CommitDate: 2021-01-24 19:38:35 +0000
> 
>     netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
>     
>     This extends upon the RFC 6598 support to libalias/ipfw in r357092.
>     
>     Reviewed By:    manpages (bcr), donner, adrian, kp
>     Approved by:    kp (mentor)
>     MFC after:      1 month
>     Differential Revision: https://reviews.freebsd.org/D23461

git allows us to distinguish between Author and Committer.

I used this (after a discussion with my mentor) to attribute a foreign
submission (nc has no src bit) directly to the Autor instead of setting
"Submitted by:" (as used under subversion)

Question: What is the prefered method to commit for an other person?

traditional:
> Author: committer
> Commit: committer
>
> patch
> Submitted by: author

or (as above):
> Author: author
> Commit: committer
>
> patch

Any opinions?