From owner-cvs-all  Fri Sep  7 16:25:15 2001
Delivered-To: cvs-all@freebsd.org
Received: from arb.arb.za.net (www.tarmactroopers.co.za [196.7.148.4])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7758737B409; Fri,  7 Sep 2001 16:24:52 -0700 (PDT)
Received: (from uucp@localhost)
	by arb.arb.za.net (8.11.3/8.11.3) with UUCP id f87NO7N34529;
	Sat, 8 Sep 2001 01:24:07 +0200 (SAST)
	(envelope-from mark@grondar.za)
Received: from grondar.za (localhost [127.0.0.1])
	by grimreaper.grondar.za (8.11.6/8.11.4) with ESMTP id f87IDV296035;
	Fri, 7 Sep 2001 19:13:31 +0100 (BST)
	(envelope-from mark@grondar.za)
Message-Id: <200109071813.f87IDV296035@grimreaper.grondar.za>
To: Hajimu UMEMOTO <ume@mahoroba.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/su Makefile su.c 
References: <20010908.013941.59479858.ume@mahoroba.org> 
In-Reply-To: <20010908.013941.59479858.ume@mahoroba.org> ; from Hajimu UMEMOTO <ume@mahoroba.org>  "Sat, 08 Sep 2001 01:39:41 +0900."
Date: Fri, 07 Sep 2001 19:13:30 +0100
From: Mark Murray <mark@grondar.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> markm>   Back out (with prejudice) the last WARNS=2 fix. I cannot understand
> markm>   its failure mode, and will revisit it later.
>   
> If you mean `su user -c command' breakage, this patch fixes it:

Yeah :-)

I have exactly this fix in my sources, and when I've built it a
couple of times and I've got my head around why the previous
one didn't work, I'll commit it.

M

> Index: usr.bin/su/su.c
> diff -u usr.bin/su/su.c.orig usr.bin/su/su.c
> --- usr.bin/su/su.c.orig	Fri Sep  7 18:21:44 2001
> +++ usr.bin/su/su.c	Fri Sep  7 18:24:18 2001
> @@ -116,7 +116,7 @@
>  	login_cap_t	*lc;
>  	union {
>  		const char	**a;
> -		char		* const b[1];
> +		char		* const *b;
>  	} 		np;
>  	uid_t		ruid;
>  	gid_t		gid;
> 
> --
> Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
> ume@mahoroba.org  ume@bisd.hitachi.co.jp  ume@{,jp.}FreeBSD.org
> http://www.imasy.org/~ume/
-- 
Mark Murray
Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message