From owner-freebsd-ports@FreeBSD.ORG Thu Jul 3 10:26:16 2014 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 64DF5DCA; Thu, 3 Jul 2014 10:26:16 +0000 (UTC) Received: from mail-la0-x22e.google.com (mail-la0-x22e.google.com [IPv6:2a00:1450:4010:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3B0F25FE; Thu, 3 Jul 2014 10:26:15 +0000 (UTC) Received: by mail-la0-f46.google.com with SMTP id el20so7825669lab.5 for ; Thu, 03 Jul 2014 03:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sQJr8cN2Z4+KwFJOs52+gfPd8MD4P0vVD7bduCZlD2Y=; b=ia2MnTOjdS/51eA85fzrr2xepMJcJv12qY1gG/4VtZs2vNHdsbIL6ApBvPCMBQzKoM b3laeRlBJ/ng823yq6GxBihegTWtUWUZXdqlG+g9Af7t1Hn/53CYQzu12NLMekVT8+mN vpL5fjR8CQnyawYunAaSU+4T5qqQh+OKLG3e5XZled+dpeWUVPJlT154VRKuib2Zx4Ck dqPrTx69tldHPigvWiUmGKtKr4S9i503z/inS8FWZX4VMxLHxHZnq1rJJxCoiB3qeu0P j8fhwEjYl3IluZYjt6ibrmC9+daazuqM7bksasAoiTXHNtQqPCNMCevohIsuR1VHUXFY fiFQ== X-Received: by 10.112.143.8 with SMTP id sa8mr278468lbb.89.1404383173654; Thu, 03 Jul 2014 03:26:13 -0700 (PDT) Received: from [10.0.1.2] (ip-95-220-95-94.bb.netbynet.ru. [95.220.95.94]) by mx.google.com with ESMTPSA id bd3sm35474920lbc.14.2014.07.03.03.26.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Jul 2014 03:26:11 -0700 (PDT) Sender: Dmitry Sivachenko Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: Patch (not perfect but half way there) for DBIx::SearchBuilder... From: Dmitry Sivachenko In-Reply-To: <53B4F7DE.9090300@FreeBSD.org> Date: Thu, 3 Jul 2014 14:26:10 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <53B4C581.5060508@sorbs.net> <53B4F7DE.9090300@FreeBSD.org> To: Matthew Seaman X-Mailer: Apple Mail (2.1878.2) Cc: ports@freebsd.org, Michelle Sullivan X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2014 10:26:16 -0000 On 03 =D0=B8=D1=8E=D0=BB=D1=8F 2014 =D0=B3., at 10:27, Matthew Seaman = wrote: > On 03/07/2014 03:52, Michelle Sullivan wrote: >> Matthew, "Demon" (cc'd you two specifically because the patch affects >> ports you maintain directly) >>=20 >> I created a patch a while ago and sent it off to Jesse and the = RT-Users >> mailing list to fix extremely slow loading of tickets for = Request-Tracker. >>=20 >> The patch is for DBIx::Searchbuilder->Fields() and you can see it = here: >> https://rt.cpan.org/Public/Ticket/Attachment/WithHeaders/733854 (bug: >> https://rt.cpan.org/Public/Bug/Display.html?id=3D96902 ) >>=20 >> If it were to be shipped as an 'option' in FreeBSD ports would it be >> attached to DBIx::SearchBuilder or RT 4.x? (the patch is against >> DBIx::SearchBuilder, but very specifically affects RT) As far as I remember, Jesse is also the author of DBIx::Searchbuilder, = right? If I were you, I would try to find a consensus with him and push the = change upstream rather than invent our own solution. Usually patches in FreeBSD ports are those that needed to "port" = software to FreeBSD, so they are FreeBSD-specific. Other than that we ship what author of software did.=