From owner-svn-src-all@freebsd.org  Wed Oct 24 15:01:18 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66121FEDC9B;
 Wed, 24 Oct 2018 15:01:18 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D8BCE96BE6;
 Wed, 24 Oct 2018 15:01:17 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w9OF17p8089782
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 24 Oct 2018 18:01:10 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w9OF17p8089782
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id w9OF17BQ089781;
 Wed, 24 Oct 2018 18:01:07 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Wed, 24 Oct 2018 18:01:07 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Toomas Soome <tsoome@me.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r339673 - head/stand/libsa
Message-ID: <20181024150107.GE5335@kib.kiev.ua>
References: <201810232311.w9NNBc4n031783@repo.freebsd.org>
 <4893BA79-ED08-401E-9AFD-4A9BD71A076C@me.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4893BA79-ED08-401E-9AFD-4A9BD71A076C@me.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 15:01:18 -0000

On Wed, Oct 24, 2018 at 08:33:19AM +0300, Toomas Soome wrote:
> 
> 
> > On 24 Oct 2018, at 02:11, Konstantin Belousov <kib@FreeBSD.org> wrote:
> > 
> > Author: kib
> > Date: Tue Oct 23 23:11:38 2018
> > New Revision: 339673
> > URL: https://svnweb.freebsd.org/changeset/base/339673
> > 
> > Log:
> >  Fix stand/ build after r339671.
> > 
> >  ffs_subr.c requires calculate_crc32c() from libkern.  Unfortunately we
> >  cannot just add libkern/crc32.c to libstand because crc32.o is already
> >  compiled from contrib/zlib/crc32.c. Use the include trick to rename
> >  the source.
> > 
> >  Note that libstand also provides crc32.c which seems to be unused.
> 
> It is used by part.c, by the GPT functions. However, if we have non-optional compile case for crc32, it is not hard to update part.c and drop the unused instance.

My point is that static library cannot usefully contain two files with the
same name.  I believe that libstand.a provides crc32.o compiled from the
contrib/zlib location.