Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Jan 2019 07:05:59 -0800
From:      John Hixson <jhixson@freebsd.org>
To:        Ruslan Makhmatkhanov <cvs-src@yandex.ru>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r491567 - in head/net: . py-ifaddr
Message-ID:  <20190129150558.GD83860@pcbsd.divinix.org>
In-Reply-To: <2964250e-028e-ec9c-d1c6-f1b7afea6487@yandex.ru>
References:  <201901291452.x0TEq8I7021248@repo.freebsd.org> <2964250e-028e-ec9c-d1c6-f1b7afea6487@yandex.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 29, 2019 at 06:02:08PM +0300, Ruslan Makhmatkhanov wrote:
> Hi John,
> 
> John Hixson wrote on 1/29/19 5:52 PM:
> > Author: jhixson
> > Date: Tue Jan 29 14:52:08 2019
> > New Revision: 491567
> > URL: https://svnweb.freebsd.org/changeset/ports/491567
> > 
> > Log:
> >    [New port] net/py-ifaddr: Python library to enumerate all network interfaces
> >    
> >    Approved by:	araujo (mentor), miwi (mentor)
> >    Differential Revision:	https://reviews.freebsd.org/D19013
> > 
> > Added:
> >    head/net/py-ifaddr/
> >    head/net/py-ifaddr/Makefile   (contents, props changed)
> >    head/net/py-ifaddr/distinfo   (contents, props changed)
> >    head/net/py-ifaddr/pkg-descr   (contents, props changed)
> > Modified:
> >    head/net/Makefile
> 
> [...]
> 
> > 
> > Added: head/net/py-ifaddr/Makefile
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/net/py-ifaddr/Makefile	Tue Jan 29 14:52:08 2019	(r491567)
> > @@ -0,0 +1,27 @@
> > +# Created by: John Hixson<jhixson@FreeBSD.org>
> > +# $FreeBSD$
> > +
> > +PORTNAME=	ifaddr
> > +PORTVERSION=	0.1.6
> > +CATEGORIES=	net python
> > +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> > +
> > +MAINTAINER=	jhixson@FreeBSD.org
> > +COMMENT=	Python Library to enumerate all network interfaces
> > +
> > +LICENSE=	MIT
> > +
> > +USES=		python:2.7+
> > +
> > +USE_PYTHON=	autoplist distutils
> > +
> > +USE_GITHUB=	yes
> > +GH_ACCOUNT=	pydron
> > +
> 
> [...]
> 
> > +.include <bsd.port.pre.mk>
> > +
> > +.if ${PYTHON_MAJOR_VER} < 3
> > +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress
> > +.endif
> > +
> > +.include <bsd.port.post.mk>
> 
> You may change this with adding uncoditionally
> 
> RUN_DEPENDS=	${PY_IPADDRESS}
> 
> because in Mk/Uses/python.mk we have:
> 
> .if ${PYTHON_REL} < 3300
> PY_IPADDRESS= 
> ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR}
> .else
> PY_IPADDRESS=
> .endif
> }
> 
> It doing the same, but looking better IMHO :)

I agree. Thanks for the tip. I'll get this in as soon as I can.

- John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190129150558.GD83860>