Date: Thu, 11 Apr 2024 09:51:17 +0300
From: Gleb Popov <arrowd@freebsd.org>
To: Tatsuki Makino <tatsuki_makino@hotmail.com>
Cc: "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org>
Subject: Re: In some places, WITH_${feature}_PORTS doesn't work
Message-ID: <CALH631m9g%2BonVYD1do2grMj2LCC2prNbQZriog9TL=XzEBWQQQ@mail.gmail.com>
In-Reply-To: <SI2PR01MB5036300AACCBCAE6FF4A9E44FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
References: <SI2PR01MB5036300AACCBCAE6FF4A9E44FA052@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 11, 2024 at 9:16=E2=80=AFAM Tatsuki Makino <tatsuki_makino@hotmail.com> wrote: > > Hello. > > Since everyone does not need to debug all ports, I assume the definition = is made like WITH_DEBUG_PORTS+=3Daudio/libopenshot-audio . > This has changed the variable defined from WITH_DEBUT to _WITH_DEBUG, so = the part that switches when WITH_DEBUG is defined is malfunctioning. > e.g. https: //cgit.freebsd.org /ports/tree/Mk/Uses/cmake.mk?id=3Deafdc2db= 185d15b8c12e09afb24ae3c2cec65cea#n86 > I feel like we could add some behavior conditional on WITH_DEBUG being de= fined on individual ports, but should it be _WITH_* from now on? > > Regards. > Yes, it seems you're absolutely right. Sorry for breaking this. Would like me to fix it or you'll do that yourself?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631m9g%2BonVYD1do2grMj2LCC2prNbQZriog9TL=XzEBWQQQ>