From owner-freebsd-multimedia@FreeBSD.ORG Sat Dec 8 18:17:03 2007 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7A0016A420 for ; Sat, 8 Dec 2007 18:17:03 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao102.cox.net (eastrmmtao102.cox.net [68.230.240.8]) by mx1.freebsd.org (Postfix) with ESMTP id 7F01C13C447 for ; Sat, 8 Dec 2007 18:17:03 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo02.cox.net ([68.1.16.120]) by eastrmmtao102.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20071208181700.KKDK16464.eastrmmtao102.cox.net@eastrmimpo02.cox.net>; Sat, 8 Dec 2007 13:17:00 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo02.cox.net with bizsmtp id NJGg1Y00C4iy4EG0000000; Sat, 08 Dec 2007 13:16:41 -0500 Date: Sat, 08 Dec 2007 12:22:21 -0600 To: "Jona Joachim" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <200712060650.lB66o4kF022891@freefall.freebsd.org> <20071207231159.7ec5cc90@spaceman.my.domain> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: User-Agent: Opera Mail/9.24 (Linux) Cc: freebsd-multimedia@freebsd.org Subject: Re: ports/118458: [UPDATE] multimedia/handbrake X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Dec 2007 18:17:03 -0000 On Fri, 07 Dec 2007 17:03:06 -0600, Jeremy Messenger wro= te: > On Fri, 07 Dec 2007 16:11:59 -0600, Jona Joachim wro= te: > >> On Thu, 06 Dec 2007 15:49:16 -0600 >> "Jeremy Messenger" wrote: >> >>> On Thu, 06 Dec 2007 00:50:04 -0600, Jona Joachim >>> wrote: >>> >>> > The following reply was made to PR ports/118458; it has been noted= >>> > by GNATS. >>> > >>> > From: Jona Joachim >>> > To: bug-followup@FreeBSD.org >>> > Cc: >>> > Subject: Re: ports/118458: [UPDATE] multimedia/handbrake >>> > Date: Thu, 6 Dec 2007 07:13:02 +0100 >>> > >>> > Sorry for the excessive indentation in MASTER_SITES and DISTFILES= , >>> > it did look fine in vim... >>> >>> That's ok, I already have cleaned that in local. Thanks for update >>> HandBrake! I like what you have done with it. >>> >>> I can't get your handbrake build. I keep get this build failure with= >>> and without modify of mine. I put the '-dx' back in for jam that way= >>> I can see the verbose of build. >> > >> Hmm, it never did that to me. Were there any errors or any other >> interesting messages during the built of libdvdcss? What architecture= >> are you on? I could only test it on FreeBSD 7 Beta 1 and Beta 4 on i3= 86. >> I couldn't test it on amd64. Could you perhaps provide me a full outp= ut >> of the built? > > We have same system. :-) Don't worry, I have fixed the build when I to= ok = > look a bit deeper. I just added these lines to fix the build. > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > USE_AUTOTOOLS=3D libtool:15 > LIBTOOLFILES=3D ${WRKSRC}/contrib/a52dec/configure \ > ${WRKSRC}/contrib/libdvdcss/configure \ > ${WRKSRC}/contrib/libdvdread/configure \ > ${WRKSRC}/contrib/faac/configure \ > ${WRKSRC}/contrib/lame/configure \ > ${WRKSRC}/contrib/mpeg4ip/configure \ > ${WRKSRC}/contrib/mpeg2dec/configure \ > ${WRKSRC}/contrib/libogg/configure \ > ${WRKSRC}/contrib/libsamplerate/configure \ > ${WRKSRC}/contrib/libvorbis/configure > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > >>> - Add post-patch to get this port respect the CC/CXX/CFLAGS/etc i= n >>> each of ./configure in contrib/Jamfile. >>> - Modified patch-contrib-Jamfile on ffmpeg part to get respect >>> CC/PTHREAD_LIBS. >>> - Re-add '-dx' for verbose build in jam, easier to debug when use= r >>> report build failure. >> >> Thanks for your changes! > > No problem, I will posting an update of patch this evening or tomorrow= = > when I find time. I did a bit more than just add lines above to fix = > libdvdread build. > >>> I am not done with that, but it's far what I have right now. I am >>> planning to remove more stuff such as remove all of these -O3, -O4, >>> -O20, -funroll-loops and other flags as should be respect to our >>> CFLAGS. Feel free to take this job if you want to. Also, do you want= >>> to take the maintainership? We are willing to give up the >>> maintainership as we have no interest in HandBrake and we will >>> leaving it in dust again in future. >> >> I think HandBrake is actually a great app since it has a lot of >> interesting features like Matroska and DTS support, plus it's easy to= >> use. >> I can take maintainership if you want. > > That's up to you if you want the maintainership. :-) > >> It would be cool if other people could test it and report if it build= s >> fine for them. > > I will need someone to test with my changes too, since my DVD drive = > doesn't work very well with RELENG_7. Update patch: http://people.freebsd.org/~mezz/diff/handbrake.diff - Fix the build by add USE_AUTOTOOLS/LIBTOOLFILES. - Respect the CFLAGS, PTHREAD_LIBS, and remove some flags. - Fix mpeg4ip/configure (s|>&/|>/|g), without it the build gets fail.= - Fix ffmpeg's prefix. If I run "make PREFIX=3D/foo" and the ffmpeg w= ill be installed in /foo/ with /foo/bin/handbrake. Forces it to install in= side ${WRKSRC}/contrib/. - Replace from "cd `dirname $(>)` && CONTRIB=3D`pwd`" to "CONTRIB=3D${WRKSRC}/contrib && cd $CONTRIB/foo". It's safer way th= an the dirname because the dirname is checking on tarball, but we don't pu= t = the tarball in the ${WRKSRC}/contrib/. See in patch-contrib-Jamfile. Let me know how it works for you and others too as I haven't test it in = = runtime. Cheers, Mezz > Cheers, > Mezz > >> Best regards, >> Jona -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org