From owner-freebsd-fs@freebsd.org Mon Feb 20 11:12:10 2017 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 490EECE64ED for ; Mon, 20 Feb 2017 11:12:10 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E9AE31562 for ; Mon, 20 Feb 2017 11:12:09 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: by mail-wr0-x22e.google.com with SMTP id 89so57342862wrr.3 for ; Mon, 20 Feb 2017 03:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=+TMedQWtZQWgYzp2g/J2pQg4hL4OHv7Fg6sA+GCXL3M=; b=sYjHzWoRy5GFBglnb9t8o9whauLfklLqGzAjg402pqwMYRE3kniZJDCnRjirA/+CNN 5aq6HMopBewQw9FZf31SL9loz60xLP3/XOagy797Dzm9t3SBF0Ydky3oNcwZQgZ+uj9j M6AxaUWLCazFnC9NONzkfqQqkl5Kcn3QghbhhYbI6DugsMPKfYU8NdgPmg6GuBVk+DWW pDln38fERJGuDjsCUXW/EPvst7h5iimowOvz5D2W7tB/6RcrSzEgzqgb61RabPi138C7 V93y1pijaq72eoYwPR4w896HVHwe//Kde8iWLjo+ifY4rvC77mRo+puJAltGSI4KzmJ1 yf/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=+TMedQWtZQWgYzp2g/J2pQg4hL4OHv7Fg6sA+GCXL3M=; b=TdHm3gmOBNjg3FKTGss8D/hjqisjYH9N2tSsStMtNs7YDgQZv1UOxYVtArUB5pg6JK RSqvXVXmSYTAJUiDm2/dYqzqMBIQZ8ir3rd76VcQ4gQaOU6pDUKBISj2fSm0UxDtVyyG swAN0+7SZgHQpD9+1T69RTr+VRCYr1pWMrNn5+LduXOLy/xmLAmGdb4EVOcKu8eVZRxz OequUKhtTlqDb6iDjn3vWM3AuYS9CE/1NLzJN2Pgaq04UmbTukGBJtZqpy50JVANdLH5 Vh4t4Z2z5Ji6zloHKGFq82WwnFro367nreU8i4R0InE7nuvw96E71nUMFllY9sRIUNMA oeiQ== X-Gm-Message-State: AMke39mIpxVS7AX1beimJ/t7uW4WhWqrQxS78yA/68jbgJVvqdnAvxHEYkErdryBuaYI9h9f X-Received: by 10.223.140.18 with SMTP id z18mr15411587wra.6.1487589128034; Mon, 20 Feb 2017 03:12:08 -0800 (PST) Received: from [10.10.1.58] ([185.97.61.26]) by smtp.gmail.com with ESMTPSA id d42sm24329486wrd.7.2017.02.20.03.12.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Feb 2017 03:12:07 -0800 (PST) Subject: Re: major code change for .zfs To: freebsd-fs@freebsd.org References: <34c1e635-4f38-d483-bcf9-768311d7c726@FreeBSD.org> From: Steven Hartland Message-ID: Date: Mon, 20 Feb 2017 11:12:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2017 11:12:10 -0000 On 20/02/2017 10:27, Andriy Gapon wrote: > On 23/08/2016 11:43, Andriy Gapon wrote: >> Please review and test a change to .zfs code that is intended to make the code >> aligned with FreeBSD VFS and, as such, more stable: >> https://reviews.freebsd.org/D7421 >> >> The change removes two features. >> .zfs/shares is gone because it was unused on FreeBSD anyway. We can restore >> that when we need it. >> An ability to take a snapshot by creating a directory under .zfs/snapshot is >> removed. I hope that you didn't use it. Please do not start using it now :-) >> Again, this feature can be restored with some work. >> The reason I removed it is that its companion features of destroying and >> renaming snapshots were already missing on FreeBSD, and properly implementing >> the feature required some more work. > This is a heads-up that I am going to commit the change. > If you have objections or concerns please speak up. > Thanks! > The only thing I would suggest is that given its invasive nature you way want to add an entry to UPDATING? Regard Steve