Date: Tue, 29 Aug 2023 09:29:04 +0200 From: Moin Rahman <bofh@freebsd.org> To: v@fatpipi.com Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 364f59940199 - main - net/lavinmq: Fix build with openssl3 Message-ID: <0BC50B76-6EA7-40B9-9EF3-8B83412837B8@freebsd.org> In-Reply-To: <CAB_qb69yUZSOoU203B4_=RpwOdzoAWwpHcSsLR7bT2HhwK9Vhg@mail.gmail.com> References: <202307261747.36QHlGhN053216@gitrepo.freebsd.org> <CAB_qb69yUZSOoU203B4_=RpwOdzoAWwpHcSsLR7bT2HhwK9Vhg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_761A6E42-6FC2-4FBA-85A3-65D57FFE71CF Content-Type: multipart/alternative; boundary="Apple-Mail=_56ECD305-613F-4F6F-9EEE-2770404D8E06" --Apple-Mail=_56ECD305-613F-4F6F-9EEE-2770404D8E06 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 29, 2023, at 9:18 AM, Vanilla Hsu <vanilla@fatpipi.com> wrote: >=20 > I think the root cause should be lang/crystal, not lavinmq. > -- > with extra patches, crystal only build with openssl 1.1, not = compatible with openssl3. Yes indeed. Looks like the dirty hack just applies on OSREL < 15 making = it bypass the test and build while other ports dependent on that fails. > Muhammad Moinur Rahman <bofh@freebsd.org <mailto:bofh@freebsd.org>> = =E6=96=BC 2023=E5=B9=B47=E6=9C=8827=E6=97=A5 =E9=80=B1=E5=9B=9B = =E4=B8=8A=E5=8D=881:47=E5=AF=AB=E9=81=93=EF=BC=9A >> The branch main has been updated by bofh: >>=20 >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D364f59940199e45a608ea2c53363d0= 8243e3aa93 = <https://cgit.freebsd.org/ports/commit/?id=3D364f59940199e45a608ea2c53363d= 08243e3aa93> >>=20 >> commit 364f59940199e45a608ea2c53363d08243e3aa93 >> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> AuthorDate: 2023-07-26 17:18:33 +0000 >> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> CommitDate: 2023-07-26 17:47:05 +0000 >>=20 >> net/lavinmq: Fix build with openssl3 >>=20 >> Approved by: portmgr (blanket) >> Sponsored by: The FreeBSD Foundation >> --- >> net/lavinmq/Makefile | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >>=20 >> diff --git a/net/lavinmq/Makefile b/net/lavinmq/Makefile >> index 5ae75f50cfc0..bf6c119b8173 100644 >> --- a/net/lavinmq/Makefile >> +++ b/net/lavinmq/Makefile >> @@ -11,8 +11,6 @@ WWW=3D https://www.lavinmq.com/ >>=20 >> LICENSE=3D APACHE20 >>=20 >> -BROKEN_FreeBSD_14=3D Incompatible with OpenSSL 3.0 in 14-CURRENT >> - >> BUILD_DEPENDS=3D crystal:lang/crystal \ >> help2man:misc/help2man \ >> shards:devel/shards >> @@ -40,6 +38,12 @@ OPTIONS_DEFINE=3D DOCS >> SHARDS_ENV=3D --time --verbose --production --release --no-color = --stats \ >> --static >>=20 >> +.include <bsd.port.options.mk <http://bsd.port.options.mk/>>; >> + >> +.if ( ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400092 && = ${SSL_DEFAULT} =3D=3D base ) || ${SSL_DEFAULT:Mopenssl3*} >> +CXXFLAGS+=3D -DOPENSSL_API_COMPAT=3D0x30000000L >> +.endif >> + >> post-extract: >> # force shards to use local paths, not git repos, for dependencies >> @${RM} ${WRKSRC}/shard.lock --Apple-Mail=_56ECD305-613F-4F6F-9EEE-2770404D8E06 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; = -webkit-nbsp-mode: space; line-break: = after-white-space;"><br><div><br><blockquote type=3D"cite"><div>On Aug = 29, 2023, at 9:18 AM, Vanilla Hsu <vanilla@fatpipi.com> = wrote:</div><br class=3D"Apple-interchange-newline"><div><div = dir=3D"ltr">I think the root cause should be lang/crystal, not = lavinmq.<div>--</div><div>with extra patches, crystal only build with = openssl 1.1, not compatible with = openssl3.</div></div></div></blockquote>Yes indeed. Looks like the dirty = hack just applies on OSREL < 15 making it bypass the test and build = while other ports dependent on that = fails.</div><div><br></div><div><br><blockquote type=3D"cite"><div><div = class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Muhammad = Moinur Rahman <<a = href=3D"mailto:bofh@freebsd.org">bofh@freebsd.org</a>> =E6=96=BC = 2023=E5=B9=B47=E6=9C=8827=E6=97=A5 =E9=80=B1=E5=9B=9B = =E4=B8=8A=E5=8D=881:47=E5=AF=AB=E9=81=93=EF=BC=9A<br></div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex">The branch main has been updated by = bofh:<br> <br> URL: <a = href=3D"https://cgit.freebsd.org/ports/commit/?id=3D364f59940199e45a608ea2= c53363d08243e3aa93" rel=3D"noreferrer" = target=3D"_blank">https://cgit.FreeBSD.org/ports/commit/?id=3D364f59940199= e45a608ea2c53363d08243e3aa93</a><br> <br> commit 364f59940199e45a608ea2c53363d08243e3aa93<br> Author: Muhammad Moinur Rahman = <bofh@FreeBSD.org><br> AuthorDate: 2023-07-26 17:18:33 +0000<br> Commit: Muhammad Moinur Rahman = <bofh@FreeBSD.org><br> CommitDate: 2023-07-26 17:47:05 +0000<br> <br> net/lavinmq: Fix build with openssl3<br> <br> Approved by: portmgr (blanket)<br> Sponsored by: The FreeBSD Foundation<br> ---<br> net/lavinmq/Makefile | 8 ++++++--<br> 1 file changed, 6 insertions(+), 2 deletions(-)<br> <br> diff --git a/net/lavinmq/Makefile b/net/lavinmq/Makefile<br> index 5ae75f50cfc0..bf6c119b8173 100644<br> --- a/net/lavinmq/Makefile<br> +++ b/net/lavinmq/Makefile<br> @@ -11,8 +11,6 @@ WWW=3D <a = href=3D"https://www.lavinmq.com/" rel=3D"noreferrer" = target=3D"_blank">https://www.lavinmq.com/</a><br>; <br> LICENSE=3D APACHE20<br> <br> -BROKEN_FreeBSD_14=3D Incompatible with OpenSSL 3.0 = in 14-CURRENT<br> -<br> BUILD_DEPENDS=3D crystal:lang/crystal \<br> = help2man:misc/help2man \<br> = shards:devel/shards<br> @@ -40,6 +38,12 @@ OPTIONS_DEFINE=3D DOCS<br> SHARDS_ENV=3D --time --verbose --production --release = --no-color --stats \<br> --static<br> <br> +.include <<a href=3D"http://bsd.port.options.mk/" rel=3D"noreferrer" = target=3D"_blank">bsd.port.options.mk</a>><br> +<br> +.if ( ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400092 = && ${SSL_DEFAULT} =3D=3D base ) || ${SSL_DEFAULT:Mopenssl3*}<br> +CXXFLAGS+=3D -DOPENSSL_API_COMPAT=3D0x30000000L<br> +.endif<br> +<br> post-extract:<br> # force shards to use local paths, not git repos, for = dependencies<br> @${RM} ${WRKSRC}/shard.lock<br> </blockquote></div> </div></blockquote></div><br></body></html>= --Apple-Mail=_56ECD305-613F-4F6F-9EEE-2770404D8E06-- --Apple-Mail=_761A6E42-6FC2-4FBA-85A3-65D57FFE71CF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmTtnkBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJHplw/+LDnoM1XWnRDmGDHuXSBKHivQoJ937Un7MpDMApR6kmtGeIslsttSJsYd fX4RkqvCsyEUIzqYkU4dBqxPx1z6SlE+6kpsIKl3ie7/T0AL4Ao/2qFkf5T7Z8be 5gqhtt6/E8SLdZ1JoQYFim+aGlU34DFl3gIrsZhzbxBHpXnrS8I1CN8yG5SlaZSC QlMBgBrwx/dWPHi+NXwTkrqBLDIV5BXUryjzTw2KwGIL5BV3ws89K3x0G8zooe0N hflMumMFaDPZIti0p5jKWLYFLgvw/Ih+vVZxzmolo2nvM2VkMFlfqUAIvJMEaZ0Q cyPB3/JQ1l1aBKwhUI4vw4Tt7CZpPN91OM82qIjBs2rRnE9sDNEueMixWRRUMAFq CeADcADA7IB6fFBSZGWsW0J8M+f3r+vkqzSpYDaxzVViByJaikE0/OvFVylboWEM ADndGew3H9pwNZxBU9E+ZSjBPr/qvCsOXKnW/sicOTGmC+wDooUZtEiM5WEd7GU2 6Fcvsu6M8O7aCe4z0dx1B3hy7RTEqI+JgdbV0qKyHbGFrH42fmqcEpjue2G2HDVv 5ABgkQNGRqNEs2eHt/SREWH4yE8j24SbYmrSb1wqSH/lbe7xknj09wjjaMGqSt+d O/T2v8TMp9peMB4cwaVT/EbY3ZD85aKlWVLexUqM2JlJisRfIZ8= =6Nab -----END PGP SIGNATURE----- --Apple-Mail=_761A6E42-6FC2-4FBA-85A3-65D57FFE71CF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0BC50B76-6EA7-40B9-9EF3-8B83412837B8>