From owner-svn-ports-head@FreeBSD.ORG Sun Mar 23 16:20:54 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD7CE8A9 for ; Sun, 23 Mar 2014 16:20:53 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AAD48ADE for ; Sun, 23 Mar 2014 16:20:53 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2NGKrZm035200 for ; Sun, 23 Mar 2014 16:20:53 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2NGKr3o035195 for svn-ports-head@freebsd.org; Sun, 23 Mar 2014 16:20:53 GMT (envelope-from bdrewery) Received: (qmail 25539 invoked from network); 23 Mar 2014 11:20:51 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 23 Mar 2014 11:20:51 -0500 Message-ID: <532F09E2.6090309@FreeBSD.org> Date: Sun, 23 Mar 2014 11:20:50 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r348866 - head/ports-mgmt/poudriere-devel References: <201403231540.s2NFeBjV061182@svn.freebsd.org> <9753239EA269BEFE3D11835F@atuin.in.mat.cc> <532F08B7.8010602@FreeBSD.org> <79C5E9B2B1255838D240E362@atuin.in.mat.cc> In-Reply-To: <79C5E9B2B1255838D240E362@atuin.in.mat.cc> X-Enigmail-Version: 1.6 OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AwGoLb42isPCm2ORoIb951BpW8BGxOtEh" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Mar 2014 16:20:54 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AwGoLb42isPCm2ORoIb951BpW8BGxOtEh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 3/23/2014 11:18 AM, Mathieu Arnold wrote: >=20 >=20 > +--On 23 mars 2014 11:15:51 -0500 Bryan Drewery > wrote: > | On 3/23/2014 11:11 AM, Mathieu Arnold wrote: > |> +--On 23 mars 2014 15:40:11 +0000 Bryan Drewery > |> wrote: > |> | .include > |> | =20 > |> | +post-install: > |> | .if ${PORT_OPTIONS:MZSH} > |> | -PLIST_FILES+=3D share/zsh/site-functions/_poudriere > |> | -PLIST_DIRSTRY+=3D share/zsh/site-functions > |> | -PLIST_DIRSTRY+=3D share/zsh/ > |> | -.else > |> | -MAKE_ENV+=3D NO_ZSH=3Dyes > |> | + @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ > |> | + ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \ > |> | + ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ > |> | .endif > |>=20 > |> I think you could do without the include and always install the file= =2E > |>=20 > |=20 > | What? >=20 > Replace: >=20 > .include >=20 > post-install: > .if ${PORT_OPTIONS:MZSH} > @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ > ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \ > ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ > .endif >=20 > With: >=20 > post-install: > @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ > ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \ > ${STAGEDIR}${PREFIX}/share/zsh/site-functions/ >=20 > The package won't register the file if the option is disabled, and it > removes the need for make to parse bsd.port.mk twice. >=20 And then there is a stage orphan. No. --=20 Regards, Bryan Drewery --AwGoLb42isPCm2ORoIb951BpW8BGxOtEh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTLwniAAoJEDXXcbtuRpfPrhIIALJjUFT8W8hngNyCLMILB5aB DJq/8ufZoHewxjBXHvA9i3RHZDJQTBxPmlil+8kjQgM9B25x1hnoOFzGNIzW7a+P x8iwAZVKdKh5wirDuAgB2EqN81pCZxzi06Ag3tkVhTnxozPrnd0mMph3xoHjoicH e8gA2xw12/M20hJZFt+uomoySMwFhFcXXj26G1slep01rRmE6ONJaZrCtw7JSD7/ fIUCFRPBOUyFi87/2JwrgJHsMtVnRrCXin5VhKeQSkGv1aLA7yjaHbTUH8spJozh pDlhpIS0t66Bjc/jJxKQBLZpxn0pdiSfELdJG+doTi8hL06RJd3U0aLM7vW0h30= =skMu -----END PGP SIGNATURE----- --AwGoLb42isPCm2ORoIb951BpW8BGxOtEh--