Date: Thu, 7 Dec 2017 07:49:17 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, hselasky@FreeBSD.org Subject: Re: svn commit: r455665 - head/audio/zynaddsubfx Message-ID: <20171207074917.GA7726@FreeBSD.org> In-Reply-To: <20171206175217.GV68137@fc.opsec.eu> References: <201712061730.vB6HU6hn021797@repo.freebsd.org> <20171206174407.GA82869@FreeBSD.org> <20171206175217.GV68137@fc.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 06, 2017 at 06:52:17PM +0100, Kurt Jaeger wrote: > > > Log: > > > audio/zynaddsubfx: fix build on cur, 10.x by force llvm40 > > > > Commit message does not explain what was the original problem, so it's > > hard to judge whether attempted solution is correct or not. > > Yes, as usual the saying goes: look at the PR, and you'll find the > links to the build logs that failed. hps will probably dig into it > if he finds time. Kurt, Sorry, but this does not work this way. Commit logs should be self- sufficient, elaborate, and completely describing original problem, analysis of it, and rationale for attempted solution. Bugzilla can go offline, links to the builds logs become stale and 404. > Would we add it if it would not be missing? Well I don't know, because it was not mentioned in the commit log. :-) People often commit unintended changes. That's why it is important to provide elaborate commit message which explains everything that went to the commit batch. Not just it would be helpful to future readers, it would also be helpful to the committer (like catching unrelated and/or bogus changes that somehow sneaked in). > > > +.include <bsd.port.options.mk> > > > > What is this .include <bsd.port.options.mk> needed for? > > hps added it, and so it went in. I doubt it's necessary, so hps > can remove it when he updates the port the next time. hps@ is not a ports committer; it is your responsibility to thoroughly review proposed changes and clarify any "doubts". It's also OK, and actually encouraged, to ask for a third pair of eyes. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171207074917.GA7726>