From owner-svn-src-all@FreeBSD.ORG  Sat Mar 20 05:21:15 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53D10106566B;
	Sat, 20 Mar 2010 05:21:15 +0000 (UTC)
	(envelope-from neel@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 420558FC08;
	Sat, 20 Mar 2010 05:21:15 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2K5LFit076999;
	Sat, 20 Mar 2010 05:21:15 GMT (envelope-from neel@svn.freebsd.org)
Received: (from neel@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2K5LFNX076997;
	Sat, 20 Mar 2010 05:21:15 GMT (envelope-from neel@svn.freebsd.org)
Message-Id: <201003200521.o2K5LFNX076997@svn.freebsd.org>
From: Neel Natu <neel@FreeBSD.org>
Date: Sat, 20 Mar 2010 05:21:15 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r205363 - head/sys/mips/sibyte
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Mar 2010 05:21:15 -0000

Author: neel
Date: Sat Mar 20 05:21:14 2010
New Revision: 205363
URL: http://svn.freebsd.org/changeset/base/205363

Log:
  Make sure that the registers 'v0' and 'v1' are properly sign-extended
  when sb_load64() returns.
  
  Some 32-bit arithmetic operations (e.g. subu) have unpredicatable results
  when operating on 64-bit registers that are not properly sign-extended.

Modified:
  head/sys/mips/sibyte/sb_asm.S

Modified: head/sys/mips/sibyte/sb_asm.S
==============================================================================
--- head/sys/mips/sibyte/sb_asm.S	Sat Mar 20 05:11:56 2010	(r205362)
+++ head/sys/mips/sibyte/sb_asm.S	Sat Mar 20 05:21:14 2010	(r205363)
@@ -53,14 +53,14 @@ LEAF(sb_load64)
 	move	v0, v1
 #if _BYTE_ORDER == _BIG_ENDIAN
 	dsll32	v1, v1, 0
-	dsrl32	v1, v1, 0	/* v1 = lower_uint32(result) */
+	dsra32	v1, v1, 0	/* v1 = lower_uint32(result) */
 	jr	ra
-	dsrl32	v0, v0, 0	/* v0 = upper_uint32(result) */
+	dsra32	v0, v0, 0	/* v0 = upper_uint32(result) */
 #else
 	dsll32	v0, v0, 0
-	dsrl32	v0, v0, 0	/* v0 = lower_uint32(result) */
+	dsra32	v0, v0, 0	/* v0 = lower_uint32(result) */
 	jr	ra
-	dsrl32	v1, v1, 0	/* v1 = upper_uint32(result) */
+	dsra32	v1, v1, 0	/* v1 = upper_uint32(result) */
 #endif
 END(sb_load64)