From owner-freebsd-current@freebsd.org Wed Oct 23 08:42:39 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7805D173F11; Wed, 23 Oct 2019 08:42:39 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46ykQj2XXMz3MZL; Wed, 23 Oct 2019 08:42:37 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 46ykQY32JVz3lJt; Wed, 23 Oct 2019 08:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:references:from:from:subject:subject:received :received; s=20151023; t=1571820148; bh=6RRUTZ/P3dlUdYdYnGg6RDpd yFqE2e3jZ3paH37Ooyc=; b=F+koBR+ck5nW7LgagWWZ0FabUE6/enKG0FuINrNC RrcFHzSu5lp9LaxlE8fyaS1HknJhd4Wmr40fBUhX+aGX6R1MDtkLsMs6ovMgdiVS QICqeYtfvdPOS6WRqcXRF8k1Xfy67r7HfC6uAsw1IfMbvf95T4IGvHa7dTG5aL14 pkw= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id C-jUusdFRtKp; Wed, 23 Oct 2019 08:42:28 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:e15d:7246:83c4:782d]) by mail.daemonic.se (Postfix) with ESMTPSA id 46ykQW6dDBz3c7Z; Wed, 23 Oct 2019 08:42:27 +0000 (UTC) Subject: Re: DRM-current-kmod is still a problem at r353339 From: Niclas Zeising To: Mark Johnston Cc: Neel Chauhan , Mateusz Guzik , Evilham , FreeBSD Current , owner-freebsd-current@freebsd.org References: <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> <20191017210510.GC6447@raichu> <96d8f37a-179b-ecad-62d1-5a097d30c0ed@daemonic.se> Message-ID: <29e29759-18bc-6747-ab11-e15eea4ac738@daemonic.se> Date: Wed, 23 Oct 2019 10:42:19 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <96d8f37a-179b-ecad-62d1-5a097d30c0ed@daemonic.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46ykQj2XXMz3MZL X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=daemonic.se header.s=20151023 header.b=F+koBR+c; dmarc=pass (policy=none) header.from=daemonic.se; spf=pass (mx1.freebsd.org: domain of zeising@daemonic.se designates 2607:f740:d:20::25 as permitted sender) smtp.mailfrom=zeising@daemonic.se X-Spamd-Result: default: False [-6.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[daemonic.se:s=20151023]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-3.71)[ip: (-9.76), ipnet: 2607:f740:d::/48(-4.88), asn: 36236(-3.85), country: US(-0.05)]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[daemonic.se:+]; DMARC_POLICY_ALLOW(-0.50)[daemonic.se,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:2607:f740:d::/48, country:US]; TAGGED_FROM(0.00)[freebsd]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2019 08:42:39 -0000 On 2019-10-21 10:13, Niclas Zeising wrote: > On 2019-10-17 23:05, Mark Johnston wrote: >> On Thu, Oct 17, 2019 at 10:31:12PM +0200, Niclas Zeising wrote: >>> On 2019-10-17 21:53, markj@freebsd.org wrote: >>>> On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: >>>>> On 2019-10-16 18:57, Neel Chauhan wrote: >>>>>> While drm-current-kmod worked for a little while, it broke with=20 >>>>>> r353645. >>>>>> >>>>>> https://i.imgur.com/Q5nYZf2.jpg >>>>>> >>>>>> I'm using the same HP Spectre that I used earlier (where it worked= =20 >>>>>> and >>>>>> where it panicked). >>>>>> >>>>> >>>>> That commit looks unrelated, it touches the wbwd and superio driver= s, >>>>> nothing else.=C2=A0 Any chance you can bisect exactly which revisio= n that >>>>> caused the new issues? >>>> >>>> I believe it was the recent work on the vm page busy state, r353539 >>>> specifically.=C2=A0 This patch should fix it; we don't yet have a >>>> __FreeBSD_version number bump on which to gate the patch. >>>> >>>> diff --git a/linuxkpi/gplv2/src/linux_page.c=20 >>>> b/linuxkpi/gplv2/src/linux_page.c >>>> index e2b85c45c..060ae85ed 100644 >>>> --- a/linuxkpi/gplv2/src/linux_page.c >>>> +++ b/linuxkpi/gplv2/src/linux_page.c >>>> @@ -239,7 +239,7 @@ retry: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 page =3D vm_page_lookup(devobj, i); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (page =3D=3D NULL) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 continue; >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = if (vm_page_sleep_if_busy(page, "linuxkpi")) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto retry; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 cdev_pager_free_page(devobj, page); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> >>> Hi! >>> Hopefully someone can confirm that this patch to drm-current-kmod or >>> drm-devel-kmod fixes the issue.=C2=A0 I won't be able to work on this= before >>> the weekend at the earliest, I'm afraid. >>> Mark, is it possible to get a belated version bump for this fix, and >>> what changed to require it? >> >> I committed the bump and verified the patch on amdgpu.=C2=A0 Here are = some >> PRs for the drivers: >> >> https://github.com/FreeBSDDesktop/kms-drm/pull/180 >> https://github.com/FreeBSDDesktop/kms-drm/pull/181 >=20 > Hi! > I'm working on getting this into the versions that are in ports.=C2=A0 = For=20 > drm-current-kmod it's fairly simple, but for drm-devel-kmod there are=20 > unrelated changes which I need to check if they are ready to go in or=20 > not, so it will take some more time. >=20 > Looking at the mail list thread, there seems to be a patch needed for=20 > base as well, has this been committed? drm-devel-kmod and drm-current-kmod has been updated with the above fix. If there are further issues, please let us know. Regards --=20 Niclas